Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple directives on same page share event(s) #89

Open
umdstu opened this issue Jan 12, 2016 · 3 comments
Open

Multiple directives on same page share event(s) #89

umdstu opened this issue Jan 12, 2016 · 3 comments

Comments

@umdstu
Copy link

umdstu commented Jan 12, 2016

There doesn't appear to be a way to differentiate between paginated elements on the same page when responding to their emitted events, ie. pagination:loadPage. I suggest adding an additional required scoped field, identifier, that is used in setting up events to listen on. See this branch: https://github.com/umdstu/angular-paginate-anything/tree/new-identifier-attribute

@begriffs
Copy link
Owner

Good idea. Love that you documented the changes too. Can you open a PR for this?

Also it would be good if the identifier was optional for when there is only one pagination element on the page.

@umdstu
Copy link
Author

umdstu commented Jan 13, 2016

I'll update the change this week.

@bacbos
Copy link

bacbos commented Feb 23, 2017

@umdstu Seems like a useful feature, do you still have plans of sending in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants