Skip to content

[Bug]: Exception when trying to use --archiveName on the command line #217

@neilenns

Description

@neilenns

Preflight Checklist

  • I have searched the issue tracker for a bug report that matches the one I want to file, without success.

Fabrication Toolkit Version

5.1.0

KiCad Version

9.0

What operating system are you using?

Ubuntu

Operating System Version

Linux 0bb2ed6b788a 6.6.87.2-microsoft-standard-WSL2

What arch are you using?

x64

Last Known Working Fabrication Toolkit version

No response

Expected Behavior

Passing --archiveName on the command line should allow specifying the archive name:

python3 -m com_github_bennymeg_JLC-Plugin-for-KiCad.cli -p "G1000 partial panel.kicad_pcb" --archiveName "G1000 partial panel-JLCPCB.zip"

Actual Behavior

There's an exception about not being able to call GetTitleBlock:

Exception in thread Thread-1:██████████████████████████████--| 97.50% Complete
Traceback (most recent call last):
  File "/usr/lib/python3.12/threading.py", line 1073, in _bootstrap_inner
    self.run()
  File "/root/.local/share/kicad/9.0/3rdparty/plugins/com_github_bennymeg_JLC-Plugin-for-KiCad/thread.py", line 156, in run
    baseName = self.expandTextVariables(self.options[ARCHIVE_NAME])
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/root/.local/share/kicad/9.0/3rdparty/plugins/com_github_bennymeg_JLC-Plugin-for-KiCad/thread.py", line 43, in expandTextVariables
    titleBlock = pcbnew.GetBoard().GetTitleBlock()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'GetTitleBlock'

Additional Information

If I leave off the --archiveName parameter then everything works fine. Using the plugin from within the KiCad UI seems to work fine as well if I specify an archive name in the text box for one.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions