[Bug]: Custom auto_prepend_file not being loaded unless dumps enabled

[bradyvercher]

Platform

macOS

Operating system version

macOS Sequoia 15.3.2

System architecture

Intel (x86)

Herd Version

1.18.0 (Build: 43)

PHP Version

No response

Bug description

I was loading a file in the auto_prepend_file setting in php.ini, but after upgrading to Herd Pro it only loads when dumps are enabled. My file was moved to herd_auto_prepend_file.

The dump-loader.php that replaced my file appears to short-circuit if dumps aren't enabled before loading the herd_auto_prepend_file setting.

if (!$config->dumpsEnabled()) {
    return;
}

Steps to reproduce

1. Add a file to the auto_prepend_file setting in php.ini
2. Restart Herd
3. The custom file is moved to herd_auto_prepend_file and no longer loads if dumps aren't enabled.

Relevant log output

[mpociot]

Whoops, that's not supposed to work like that 😅

You can fix this manually by editing the dump-loader.php file and move the custom auto_prepend_file logic after loading the configuration, like this:

require_once __DIR__ . '/HerdConfiguration.php';

try {
    $config = HerdConfiguration::load();
} catch (\Throwable $e) {
    return;
}
$herdAutoPrepend = HerdConfiguration::getIniValues()['herd_auto_prepend_file'] ?? '';

if (!empty($herdAutoPrepend) && file_exists($herdAutoPrepend)) {
    include_once $herdAutoPrepend;
}

// …

This will be fixed in the next release

[bradyvercher]

@mpociot I made that change and it looks like it'll work until the next release. Thanks!