Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE7 star property hack used in spectrum.css causes console warnings in Safari 7 #205

Open
ispringer opened this issue Mar 31, 2014 · 2 comments

Comments

@ispringer
Copy link

spectrum.css contains css properties prefixed with "*" chars within the ".sp-container", ".sp-cf", ".sp-replacer", and ".sp-palette" selectors. For example:

*display: inline;
*zoom: 1;

I assume this is the "IE7 star property hack" described here:

http://www.ejeliot.com/blog/63

Safari 7.0.2 (and possibly earlier versions of Safari) logs warnings about these lines:

screen shot 2014-03-31 at 12 52 38 pm

Perhaps to avoid these warnings, IE conditional comments could be used instead to set IE7-specific styles.

@bgrins
Copy link
Owner

bgrins commented Apr 7, 2014

I believe that some of these could be removed entirely - for instance, we could replace the existing clearfix hack with this one: https://github.com/h5bp/html5-boilerplate/blob/master/css/main.css#L173. Conditional comments would be possible, but I'm not sure if those would target more recent versions that don't need the props specified after the star to be applied.

@bgrins
Copy link
Owner

bgrins commented Apr 7, 2014

There is a process to convert the styles / themes to SASS here: #203. We should hold off on style changes until this has landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants