New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updateUI not called #94

Open

zb3 opened this issue Jun 8, 2013 · 1 comment

zb3 commented Jun 8, 2013

this can be a problem in the following situation:

color in input: #00ffff
user enters garbage at the end of the value ex #00ffffLOL
input gets highlighted as error
user removes garbage
still highlighted, because updateUI is called only when color is different

solution:
if (tinycolor.equals(color, get())) {
updateUI(); // <- add this
return;
}

Owner

bgrins commented Jun 10, 2013

I see this, thanks! I will put in a fix for this soon.

siliconjohn pushed a commit to siliconjohn/spectrum that referenced this issue


          fixes bgrins#94

43d0850

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment