Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Apply' button to dialog #35

Open
p3732 opened this issue Mar 31, 2020 · 2 comments
Open

Add 'Apply' button to dialog #35

p3732 opened this issue Mar 31, 2020 · 2 comments

Comments

@p3732
Copy link

p3732 commented Mar 31, 2020

Hej,
first of all, this is a really nice plugin!
However, using it for the first time I was too stupid to understand that the icon needs to be set by double clicking. I expected an 'Apply' button to appear on the top right of the dialog, as it is the standard way of GTK dialogs to work.
Thus I wanted to ask, what your opinion on adding such a button is (a blue one, like used for renaming in nautilus). It would not need to replace the current way the plugin work, rather give another option (for people like me that otherwise just assume sth is broken…).

Also, a bit off-topic, do I suppose correctly, that this plugin works by listing all files in /usr/share/icons/Adwaita/512x512/places that start with 'folder'? Just curious, cause there currently is some initiative at nautilus going on to rework the properties dialog (https://gitlab.gnome.org/GNOME/nautilus/-/issues/1207 and https://gitlab.gnome.org/GNOME/nautilus/-/issues/1326) and I suppose this plugin relies on the built-in support of setting images as folder previews.

Cheers!

@bilelmoussaoui
Copy link
Owner

Hey,

I don't have the time to fix this, but feel free to send a merge request and I will hapily review and merge it.
Nop the extension doesn't depend on that at all, it uses Gio to set a custom icon of the directory and doesn't depend on whatever nautilus does

@p3732
Copy link
Author

p3732 commented Mar 31, 2020

I don't have the time to fix this, but feel free to send a merge request and I will hapily review and merge it.

I will put it on my todo list :)

Nop the extension doesn't depend on that at all, it uses Gio to set a custom icon of the directory and doesn't depend on whatever nautilus does.

Good to know, in case the decision to drop it completely is made :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants