Merge pull request #1 from binary-cats/analysis-gO1add

Apply fixes from StyleCI

Author: cyrillkalita

src/Jobs/Job.php

@@ -19,7 +19,7 @@ abstract class Job
     protected $webhookCall;
 
     /**
-     * Location of the root
+     * Location of the root.
      *
      * @var string
      */
@@ -36,17 +36,17 @@ public function __construct(WebhookCall $webhookCall)
     }
 
     /**
-     * Fetch Payload
+     * Fetch Payload.
      *
      * @return array
      */
-    protected function payload() : array
+    protected function payload(): array
     {
         return $this->webhookCall->payload;
     }
 
     /**
-     * Get the value from the payload's event data
+     * Get the value from the payload's event data.
      *
      * @param  string $key
      * @return mixed

src/Jobs/MeetingCreatedJob.php

@@ -2,9 +2,6 @@
 
 namespace BinaryCats\BigBlueButtonWebhooks\Jobs;
 
-use BinaryCats\BigBlueButtonWebhooks\Jobs\Job;
-use Spatie\WebhookClient\Models\WebhookCall;
-
 class MeetingCreatedJob extends Job
 {
     /**
@@ -14,6 +11,5 @@ class MeetingCreatedJob extends Job
      */
     public function handle()
     {
-
     }
 }

src/Webhook.php

@@ -2,8 +2,6 @@
 
 namespace BinaryCats\BigBlueButtonWebhooks;
 
-use Illuminate\Http\Request;
-
 class Webhook
 {
     /**

src/WebhookCall.php

@@ -4,20 +4,20 @@
 
 use Illuminate\Http\Request;
 use Illuminate\Support\Arr;
-use Spatie\WebhookClient\WebhookConfig;
 use Spatie\WebhookClient\Models\WebhookCall as Model;
+use Spatie\WebhookClient\WebhookConfig;
 
 class WebhookCall extends Model
 {
-    public static function storeWebhook(WebhookConfig $config, Request $request): WebhookCall
+    public static function storeWebhook(WebhookConfig $config, Request $request): self
     {
-        # payload is not proper JSON, rather is it split between three blocks
+        // payload is not proper JSON, rather is it split between three blocks
         $payload = $request->input();
-        # transform event
-        if ($event = Arr::get($payload, 'event', null) AND is_string($event)) {
+        // transform event
+        if ($event = Arr::get($payload, 'event', null) and is_string($event)) {
             $payload['event'] = json_decode($event, true);
         }
-        # create
+        // create
         return self::create([
             'name' => $config->name,
             'payload' => $payload,

src/WebhookSignature.php

@@ -2,8 +2,6 @@
 
 namespace BinaryCats\BigBlueButtonWebhooks;
 
-use Illuminate\Http\Request;
-
 class WebhookSignature
 {
     /**

tests/BigBlueButtonWebhookCallTest.php

@@ -27,21 +27,21 @@ public function setUp(): void
         $this->webhookCall = $model::create([
             'name' => 'bigbluebutton',
             'payload' => [
-                "event" => [
+                'event' => [
                     [
-                        "data" => [
-                            "type" => "event",
-                            "id" => "my.type",
-                            "attributes" => [
+                        'data' => [
+                            'type' => 'event',
+                            'id' => 'my.type',
+                            'attributes' => [
                             ],
-                            "event" => [
-                                "ts" => 1591652302962,
+                            'event' => [
+                                'ts' => 1591652302962,
                             ],
                         ],
                     ],
                 ],
-                "timestamp" => "1591652302965",
-                "domain" => "example.com",
+                'timestamp' => '1591652302965',
+                'domain' => 'example.com',
             ],
         ]);
 

tests/IntegrationTest.php

@@ -2,7 +2,6 @@
 
 namespace BinaryCats\BigBlueButtonWebhooks\Tests;
 
-use Illuminate\Support\Arr;
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Route;
 use Spatie\WebhookClient\Models\WebhookCall;
@@ -29,7 +28,7 @@ public function it_can_handle_a_valid_request()
 
         $this
             ->withHeaders([
-                'Authorization' => 'Bearer '. $this->determineBigblueButtonsignature($payload),
+                'Authorization' => 'Bearer '.$this->determineBigblueButtonsignature($payload),
             ])
             ->post('bigbluebutton-webhooks', $payload)
             ->assertSuccessful();
@@ -75,7 +74,7 @@ public function a_request_with_an_invalid_payload_will_be_logged_but_events_and_
 
         $this
             ->withHeaders([
-                'Authorization' => 'Bearer '. $this->determineBigblueButtonsignature($payload),
+                'Authorization' => 'Bearer '.$this->determineBigblueButtonsignature($payload),
             ])
             ->post('bigbluebutton-webhooks', $payload)
             ->assertStatus(400);
@@ -86,7 +85,7 @@ public function a_request_with_an_invalid_payload_will_be_logged_but_events_and_
 
         $this->assertFalse(isset($webhookCall->payload['event'][0]['data']['id']));
         $this->assertEquals([
-            'invalid_payload'
+            'invalid_payload',
         ], $webhookCall->payload);
 
         $this->assertEquals('Webhook call id `1` did not contain a type. Valid BigBlueButton webhook calls should always contain a type.', $webhookCall->exception['message']);

tests/PayloadDefinition.php

@@ -5,26 +5,26 @@
 class PayloadDefinition
 {
     /**
-     * Given the compexity of the payload, let's put is all into the same method
+     * Given the compexity of the payload, let's put is all into the same method.
      */
     public static function getPayloadDefinition(): array
     {
         return [
-            "event" => [
+            'event' => [
                 [
-                    "data" => [
-                        "type" => "event",
-                        "id" => "my.type",
-                        "attributes" => [
+                    'data' => [
+                        'type' => 'event',
+                        'id' => 'my.type',
+                        'attributes' => [
                         ],
-                        "event" => [
-                            "ts" => 1591652302962,
+                        'event' => [
+                            'ts' => 1591652302962,
                         ],
                     ],
                 ],
             ],
-            "timestamp" => "1591652302965",
-            "domain" => "example.com",
+            'timestamp' => '1591652302965',
+            'domain' => 'example.com',
         ];
     }
 }