-
-
Notifications
You must be signed in to change notification settings - Fork 547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename some rules. #5350
Comments
@Conaclos I think |
I think I would prefer |
Many of our rules use |
I already opened an issue for the first rename: #5285 |
We could also rename:
|
We began to formulate "rule naming decision-making guidance" internally last week, suggesting that biome should do the same. Since it has a large set of rules and needs to constantly migrate rules from other rule sources, this can improve the consistency of naming conventions and help refer to relevant rules in the "See Also" or "Related To" section below the rule document. |
I like the distinction between "useless" and "unnecessary" you've defined there. For convenience, I'll copy it here:
It makes sense, and anything to make naming things easier is always welcome. |
I'm glad you like it! I can understand the naming dilemma; I've had to choose between "useless" and "unnecessary" a few times myself. A fun fact is that ESLint React's initial rules were inspired by the React rules in |
@Rel1cx Why not choose |
Redundant means that there's too much of something, so it's not the same thing |
I asked because it is part of the definition of what they mean by
|
Remove dynamic regex (RegExep("", "")) support in regex-related rules (noControlCharacterInRegex and noMisleadingCharacterClass)
The text was updated successfully, but these errors were encountered: