Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename some rules. #5350

Open
ematipico opened this issue Mar 14, 2025 · 6 comments
Open

Rename some rules. #5350

ematipico opened this issue Mar 14, 2025 · 6 comments
Assignees

Comments

@ematipico
Copy link
Member

ematipico commented Mar 14, 2025

Remove dynamic regex (RegExep("", "")) support in regex-related rules (noControlCharacterInRegex and noMisleadingCharacterClass)

  • noMultipleSpacesInRegularExpressionLiterals -> noMultipleSpacesInRegex
  • noUnusedTemplateLiteral -> noUselessTemplateLiteral?
@ematipico ematipico changed the title Rename some rules. This could be made in a backward compatible way by keeping the old rule as deprecated. Rename some rules. Mar 14, 2025
@ematipico ematipico self-assigned this Mar 14, 2025
@ematipico
Copy link
Member Author

@Conaclos I think noUnusedTemplateLiteral is fine, it isn't a big deal. Is it fine to leave it out?

@arendjr
Copy link
Contributor

arendjr commented Mar 14, 2025

I think I would prefer noUnnecessaryTemplateLiteral :)

@ematipico
Copy link
Member Author

ematipico commented Mar 14, 2025

Many of our rules use noUseless*; that's why @Conaclos suggested it. Adding a new naming convention wouldn't help.

@Conaclos
Copy link
Member

I already opened an issue for the first rename: #5285
I suggested noAdjacentSpacesInRegex (See the reasoning in the issue description).

@Conaclos
Copy link
Member

Conaclos commented Mar 14, 2025

We could also rename:

  • noUnnecessaryContinue into noUselessContinue
  • noExtraBooleanCast into noUselessBooleanCast (We could keep the original name because it matches the ESLint one)
  • noRedundantUseStrict into noUselessUseStrict (Perhaps the rule should be in complexity like other noUseless* rules?)
  • noDuplicatedFields into noDuplicateFields (This is a nursery rule)

@ematipico
Copy link
Member Author

@Conaclos can you make #5285 a sub issue of #3727 ?

Otherwise it's easy to miss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants