Rename some rules.

[ematipico]

Remove dynamic regex (RegExep("", "")) support in regex-related rules (noControlCharacterInRegex and noMisleadingCharacterClass)

• noMultipleSpacesInRegularExpressionLiterals -> noMultipleSpacesInRegex
• noUnusedTemplateLiteral -> noUselessTemplateLiteral?

[ematipico]

@Conaclos I think noUnusedTemplateLiteral is fine, it isn't a big deal. Is it fine to leave it out?

[arendjr]

I think I would prefer noUnnecessaryTemplateLiteral :)

[ematipico]

Many of our rules use noUseless*; that's why @Conaclos suggested it. Adding a new naming convention wouldn't help.

[Conaclos]

I already opened an issue for the first rename: #5285
I suggested noAdjacentSpacesInRegex (See the reasoning in the issue description).

[Conaclos]

We could also rename:

• noUnnecessaryContinue into noUselessContinue
• noExtraBooleanCast into noUselessBooleanCast (We could keep the original name because it matches the ESLint one)
• noRedundantUseStrict into noUselessUseStrict (Perhaps the rule should be in complexity like other noUseless* rules?)
• noDuplicatedFields into noDuplicateFields (This is a nursery rule)

[ematipico]

@Conaclos can you make #5285 a sub issue of #3727 ?

Otherwise it's easy to miss

[Rel1cx]

https://github.com/Rel1cx/eslint-react/blob/main/.adrs/0000-choice-between-useless-and-unnecessary-in-rule-naming.md

We began to formulate "rule naming decision-making guidance" internally last week, suggesting that biome should do the same. Since it has a large set of rules and needs to constantly migrate rules from other rule sources, this can improve the consistency of naming conventions and help refer to relevant rules in the "See Also" or "Related To" section below the rule document.

[dyc3]

I like the distinction between "useless" and "unnecessary" you've defined there. For convenience, I'll copy it here:

Use "useless" to describe code that has no functional purpose under any circumstances (e.g., a forwardRef call with no ref usage).

Use "unnecessary" to describe code that is contextually redundant but not strictly non-functional (e.g., an useEffect that runs event-specific logic).

It makes sense, and anything to make naming things easier is always welcome.

[Rel1cx]

I like the distinction between "useless" and "unnecessary" you've defined there. For convenience, I'll copy it here:

Use "useless" to describe code that has no functional purpose under any circumstances (e.g., a forwardRef call with no ref usage).
Use "unnecessary" to describe code that is contextually redundant but not strictly non-functional (e.g., an useEffect that runs event-specific logic).

It makes sense, and anything to make naming things easier is always welcome.

I'm glad you like it! I can understand the naming dilemma; I've had to choose between "useless" and "unnecessary" a few times myself. A fun fact is that ESLint React's initial rules were inspired by the React rules in rome/tools.

[Conaclos]

@Rel1cx Why not choose redundant instead of unnecessary? It looks clearer to me.

[ematipico]

Redundant means that there's too much of something, so it's not the same thing

[Conaclos]

I asked because it is part of the definition of what they mean by unnecessary:

Use "unnecessary" to describe code that is contextually redundant but not strictly non-functional (e.g., an useEffect that runs event-specific logic).