Skip to content

docs: Improve Crate Documentation #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlaKC opened this issue Nov 20, 2024 · 4 comments
Open

docs: Improve Crate Documentation #205

carlaKC opened this issue Nov 20, 2024 · 4 comments
Assignees
Labels
feature New feature or request Low Priority

Comments

@carlaKC
Copy link
Contributor

carlaKC commented Nov 20, 2024

simln-lib is a crate now 🎉
But it's quite an unfriendly one (not- 🎉 ) becuase we're missing a few docs.

There are a few low-hanging fruit that we could address to fix this up.

Add a Readme

Screenshot 2024-11-20 at 13 21 04

Better documentation for exported structs / enums

Screenshot 2024-11-20 at 13 21 15
@carlaKC carlaKC added the feature New feature or request label Nov 20, 2024
@carlaKC carlaKC added this to the V2.4 milestone Feb 12, 2025
@carlaKC carlaKC self-assigned this Mar 7, 2025
@sangbida
Copy link
Contributor

Hey @carlaKC
I'm happy to pick up this one next, if you haven't started work on it yet. I'm happy to pick up something else or do some code reviews in the meantime if you've made progress on this already :)

@carlaKC carlaKC assigned sangbida and unassigned carlaKC Mar 24, 2025
@carlaKC
Copy link
Contributor Author

carlaKC commented Mar 24, 2025

Sure, feel free to get going on this!

@sangbida
Copy link
Contributor

Hello, just thought I'd drop an update here. I've been working on this slowly here: #241

The plan is to get some cln nodes up and running and create a test project to validate the Usage setup that I'm putting in and continue adding docs for the structs, traits and enums.

@carlaKC
Copy link
Contributor Author

carlaKC commented Apr 29, 2025

Made a really good start on this!

Leaving this open with the stretch goal of turning on #![deny(missing_docs)] for both simln-lib and sim-cli (+ adding all the required comments that we need to get our checks to pass with this enabled).

@carlaKC carlaKC removed this from the V2.4 milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants