Skip to content

Refactor: Do not call add_node_to_maps in validate_activities #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chuksys opened this issue Mar 26, 2025 · 0 comments · Fixed by #238
Closed

Refactor: Do not call add_node_to_maps in validate_activities #237

chuksys opened this issue Mar 26, 2025 · 0 comments · Fixed by #238
Labels
nit Small nitpicks that are picked up in testing.

Comments

@chuksys
Copy link

chuksys commented Mar 26, 2025 •
edited
Loading

Create ActivityValidationParams struct and pass to validate_activities to improve testability and reduce coupling.

          Pass these in rather than calling `add_node_to_maps` here

Originally posted by @carlaKC in #232 (comment)
@chuksys chuksys mentioned this issue Mar 26, 2025
Merged
@chuksys chuksys changed the title sim-cli/refactor: create ActivityValidationParams struct and pass to validate_activities to improve testability and reduce coupling. sim-cli/refactor: Improve testability and reduce coupling. Mar 26, 2025
@carlaKC carlaKC changed the title sim-cli/refactor: Improve testability and reduce coupling. sim-cli/refactor: Do not call add_node_to_maps in validate_activities Mar 28, 2025
@carlaKC carlaKC changed the title sim-cli/refactor: Do not call add_node_to_maps in validate_activities Refactor: Do not call add_node_to_maps in validate_activities Mar 28, 2025
@carlaKC carlaKC added the nit Small nitpicks that are picked up in testing. label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nit Small nitpicks that are picked up in testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sim-cli/refactor: do not call add_node_to_maps in validate_activities chuksys/sim-ln
2 participants
@chuksys @carlaKC