Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(chain):move txtemplate to testenv #1800

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tvpeter
Copy link
Contributor

@tvpeter tvpeter commented Jan 14, 2025

Description

This PR implements the following changes:

  • moves TxTemplate from crates/chain/tests/common/mod.rs to testenv.
  • refactors init_graph function and TxTemplate struct to use Cow
  • redoes the canonical benchmark tests introduced by Introduce O(n) canonicalization algorithm #1670 using TxTemplates

Closes #1754

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@tvpeter tvpeter force-pushed the test/move-txtemplate-to-testenv branch from 7568b90 to 3d00e54 Compare January 15, 2025 03:45
- update chain to use tx_template from testenv
- update imports in cargo.toml files
- update imports in test files
- update imports in testenv/src/lib.rs
- delete chain/tests/common/mod.rs file

[Issue: 1754]
@tvpeter tvpeter force-pushed the test/move-txtemplate-to-testenv branch from 3d00e54 to d121446 Compare January 17, 2025 12:36
- refactor tx_template struct and init_graph
to use Cow type
- update the chain test_tx_graph test to use the
updated tx_template struct and init_graph fn
- update the test_tx_graph_conflicts to use the
updated tx_template and init_graph fn
- redo the canonical benchmarks to use tx_template

[Issue: 1754]

Refactor benchmark tests to use TxGraph

Refactor all test cases to use TxGraph and
TxTemplate

[Issue: 1754]
@tvpeter tvpeter force-pushed the test/move-txtemplate-to-testenv branch from 8b81584 to 12181bb Compare January 21, 2025 10:30
@tvpeter tvpeter marked this pull request as ready for review January 21, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move TxTemplate to bdk_testenv and make it better
1 participant