diff --git a/lib/chromic_pdf/pdf/protocol_macros.ex b/lib/chromic_pdf/pdf/protocol_macros.ex index d724f71..8d5c7b6 100644 --- a/lib/chromic_pdf/pdf/protocol_macros.ex +++ b/lib/chromic_pdf/pdf/protocol_macros.ex @@ -188,12 +188,12 @@ defmodule ChromicPDF.ProtocolMacros do if JsonRPC.response?(msg, last_call_id) do cond do - function_exported?(__MODULE__, unquote(cb_name), 2) -> - apply(__MODULE__, unquote(cb_name), [state, msg]) - JsonRPC.is_error?(msg) -> {:error, JsonRPC.extract_error(msg)} + function_exported?(__MODULE__, unquote(cb_name), 2) -> + apply(__MODULE__, unquote(cb_name), [state, msg]) + true -> :ok end diff --git a/test/integration/pdf_generation_test.exs b/test/integration/pdf_generation_test.exs index 2a9bc7b..6d24a4d 100644 --- a/test/integration/pdf_generation_test.exs +++ b/test/integration/pdf_generation_test.exs @@ -34,6 +34,13 @@ defmodule ChromicPDF.PDFGenerationTest do end) end + @tag :pdftotext + test "raises an error for invalid paths, e.g. relative" do + assert_raise ChromicPDF.ChromeError, ~r/Cannot navigate to invalid URL/, fn -> + ChromicPDF.print_to_pdf({:url, "/doesnotwork"}) + end + end + @tag :pdftotext test "it waits for external resources when printing HTML content" do html = ~s()