Backport of bitfireAT/davx5#655: honor build config decision on whether users are allowed to accept custom certificates

* Honor customCertsUI build config value on whether users are allowed to accept custom certificates

Signed-off-by: Sunik Kupfer <[email protected]>

* Add kdoc

Signed-off-by: Sunik Kupfer <[email protected]>

* Update comment

Signed-off-by: Sunik Kupfer <[email protected]>

* Extract config evaluation; Update kdoc

Signed-off-by: Sunik Kupfer <[email protected]>

---------

Signed-off-by: Sunik Kupfer <[email protected]>

Author: sunkup

app/src/main/kotlin/at/bitfire/davdroid/network/HttpClient.kt

@@ -234,7 +234,10 @@ class HttpClient(
             val certManager = CustomCertManager(
                 context = context,
                 trustSystemCerts = !settingsManager.getBoolean(Settings.DISTRUST_SYSTEM_CERTIFICATES),
-                appInForeground = ForegroundTracker.inForeground
+                appInForeground = if (/* davx5-ose */ true)
+                    ForegroundTracker.inForeground  // interactive mode
+                else
+                    null                            // non-interactive mode
             )
 
             val sslContext = SSLContext.getInstance("TLS")

app/src/main/kotlin/at/bitfire/davdroid/ui/ForegroundTracker.kt

@@ -12,6 +12,10 @@ import kotlinx.coroutines.flow.asStateFlow
  */
 object ForegroundTracker {
 
+    /**
+     * Whether the app is in the foreground.
+     * Used by cert4android to known when it's possible to show the certificate trust decision dialog.
+     */
     private val _inForeground = MutableStateFlow(false)
 
     /**
@@ -32,4 +36,5 @@ object ForegroundTracker {
     fun onPaused() {
         _inForeground.value = false
     }
+
 }