Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/matomo] Exclude matomo.js from being rsynced, same as config.ini.php #76460

Closed
benemart opened this issue Jan 21, 2025 · 3 comments · Fixed by #77036
Closed

[bitnami/matomo] Exclude matomo.js from being rsynced, same as config.ini.php #76460

benemart opened this issue Jan 21, 2025 · 3 comments · Fixed by #77036
Assignees
Labels
feature-request matomo solved stale 15 days without activity triage Triage is needed

Comments

@benemart
Copy link
Contributor

Name and Version

bitnami/matomo:5.1.0

What is the problem this feature will solve?

Some officiel plugins like Media Anaytics modify the tracker file matomo.js

With the actual bitnami image, all files except config.ini.php are made persistent due to 33b63ac

 4.15.0-debian-11-r20
From this version on, all Matomo files are persisted (MATOMO_DATA_TO_PERSIST env var). During the upgrade process, they will be replaced (except the config.ini.php file) as suggested in [the official documentation](https://matomo.org/faq/on-premise/update-matomo/#the-manual-three-step-update)

What is the feature you are proposing to solve the problem?

Exclude matomo.js from the rsync command, same as config.ini.php

in /rootfs/opt/bitnami/scripts/matomo-env.sh

export MATOMO_TRACKER_FILE="${MATOMO_BASE_DIR}/matomo.js"

in /rootfs/opt/bitnami/scripts/libmatomo.sh

rsync -a "$MATOMO_BASE_DIR"/* "$MATOMO_VOLUME_DIR" --exclude "$(realpath --relative-to="$MATOMO_BASE_DIR" "$MATOMO_CONF_FILE")" --exclude "$(realpath --relative-to="$MATOMO_BASE_DIR" "$MATOMO_TRACKER_FILE")"

What alternatives have you considered?

As possible alternative:

  • specify the plugin tracker plugins/MediaAnalytics/tracker.min.js in the the header as specified in the Media Anaytics documentation but it implies to modify the code of each website
  • use a custom post init script to restore the matomo.js file from a previous save
@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

Copy link

github-actions bot commented Feb 6, 2025

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the stale 15 days without activity label Feb 6, 2025
benemart added a commit to benemart/bitnami-containers that referenced this issue Feb 6, 2025
benemart added a commit to benemart/bitnami-containers that referenced this issue Feb 7, 2025
benemart added a commit to benemart/bitnami-containers that referenced this issue Feb 7, 2025
…76460)

Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>
benemart added a commit to benemart/bitnami-containers that referenced this issue Feb 7, 2025
benemart added a commit to benemart/bitnami-containers that referenced this issue Feb 7, 2025
…76460)

Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>
benemart added a commit to benemart/bitnami-containers that referenced this issue Feb 7, 2025
…76460)

Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>
Copy link

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@bitnami-bot bitnami-bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2025
dgomezleon pushed a commit that referenced this issue Feb 12, 2025
…77036)

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue #76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue #76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

* Signed-off-by: Bénédicte Martinez [email protected]
Remove MATOMO_TRACKER_FILE variable

* Remove trailing space in ReadMe.md
Signed-off-by: Bénédicte Martinez [email protected]

* [bitnami/acmesolver] Release acmesolver-1.17.0-debian-12-r1 (#76860)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue #76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue #76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

* Signed-off-by: Bénédicte Martinez [email protected]
Remove MATOMO_TRACKER_FILE variable

Signed-off-by: Bénédicte Martinez <[email protected]>

* Remove trailing space in ReadMe.md
Signed-off-by: Bénédicte Martinez [email protected]

Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/cassandra] Release cassandra-5.0.3-debian-12-r0 (#76855)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/argo-cd] Release argo-cd-2.14.1-debian-12-r0 (#76856)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/concourse] Release concourse-7.12.1-debian-12-r1 (#76857)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/minio-client] Release minio-client-2025.2.4-debian-12-r0 (#76858)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/minio] Release minio-2025.2.3-debian-12-r0 (#76859)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/acmesolver] Release acmesolver-1.17.0-debian-12-r1 (#76860)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue #76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue #76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>

* Signed-off-by: Bénédicte Martinez [email protected]
Remove MATOMO_TRACKER_FILE variable

Signed-off-by: Bénédicte Martinez <[email protected]>

* Remove trailing space in ReadMe.md
Signed-off-by: Bénédicte Martinez [email protected]

Signed-off-by: Bénédicte Martinez <[email protected]>

* Change name variable
Signed-off-by: Bénédicte Martinez <[email protected]>

---------

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>
Co-authored-by: Bitnami Bot <[email protected]>
beertje44 pushed a commit to beertje44/bitnami-containers that referenced this issue Feb 12, 2025
…76460) (bitnami#77036)

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue bitnami#76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue bitnami#76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

* Signed-off-by: Bénédicte Martinez [email protected]
Remove MATOMO_TRACKER_FILE variable

* Remove trailing space in ReadMe.md
Signed-off-by: Bénédicte Martinez [email protected]

* [bitnami/acmesolver] Release acmesolver-1.17.0-debian-12-r1 (bitnami#76860)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue bitnami#76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue bitnami#76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

* Signed-off-by: Bénédicte Martinez [email protected]
Remove MATOMO_TRACKER_FILE variable

Signed-off-by: Bénédicte Martinez <[email protected]>

* Remove trailing space in ReadMe.md
Signed-off-by: Bénédicte Martinez [email protected]

Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/cassandra] Release cassandra-5.0.3-debian-12-r0 (bitnami#76855)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/argo-cd] Release argo-cd-2.14.1-debian-12-r0 (bitnami#76856)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/concourse] Release concourse-7.12.1-debian-12-r1 (bitnami#76857)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/minio-client] Release minio-client-2025.2.4-debian-12-r0 (bitnami#76858)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/minio] Release minio-2025.2.3-debian-12-r0 (bitnami#76859)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/acmesolver] Release acmesolver-1.17.0-debian-12-r1 (bitnami#76860)

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue bitnami#76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>

* [bitnami/matomo] Exclude matomo.js from being rsynced (issue bitnami#76460)
Signed-off-by: Bénédicte Martinez <[email protected]>

Signed-off-by: Bénédicte Martinez <[email protected]>

* Signed-off-by: Bénédicte Martinez [email protected]
Remove MATOMO_TRACKER_FILE variable

Signed-off-by: Bénédicte Martinez <[email protected]>

* Remove trailing space in ReadMe.md
Signed-off-by: Bénédicte Martinez [email protected]

Signed-off-by: Bénédicte Martinez <[email protected]>

* Change name variable
Signed-off-by: Bénédicte Martinez <[email protected]>

---------

Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bénédicte Martinez <[email protected]>
Co-authored-by: Bitnami Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request matomo solved stale 15 days without activity triage Triage is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants