Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8.4 Support? #353

Open
teamayu opened this issue Jan 18, 2025 · 1 comment
Open

PHP8.4 Support? #353

teamayu opened this issue Jan 18, 2025 · 1 comment

Comments

@teamayu
Copy link

teamayu commented Jan 18, 2025

Seems like the latest version does not support PHP8.4. Any idea when this library will be updated?

vendor\bitpay\sdk\src\BitPaySDK\PosClient.php:48

Implicitly marking parameter $environment as nullable is deprecated, the explicit nullable type must be used instead

vendor\bitpay\sdk\src\BitPaySDK\Client.php:257

BitPaySDK\Client::getInvoices(): Implicitly marking parameter $status as nullable is deprecated, the explicit nullable type must be used instead

Seems like for the most part it is compatible, but a few nullable types need tweaking. Easy fixes but just wanted to give you a heads up.

Thanks.

@bobbrodie
Copy link
Collaborator

Hi @teamayu -- we're checking this out and are making sure dependencies are ready. Since some of the platforms aren't fully up to speed yet on stable PHP 8.4 support we had a few other priorities, but will definitely get this into the pipeline for v9.2.0 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants