Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Oct 31, 2025

🎟️ Tracking

📔 Objective

Bumps at rsa, rand, to the release candidates / stable releases. This fixes a non-constant timing vulnerability in the rsa function. This requires bumping a few other crates within bitwarden-crypto as they depend transitively on rand, or rsa depends on them. Within the same crate, we cannot have different versions.

This unblocks using any newer rustcrypto library, or other rust cyrpto library, including hpke, xwing, ml-dsa, which are required for the move to pq-crypto.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Logo
Checkmarx One – Scan Summary & Details5098b4a4-3ba3-46be-9bfb-1b177b2921ff

Great job! No new security vulnerabilities introduced in this pull request

@quexten quexten changed the title Update rustcrypto deps [BEEEP] Bitwarden-crypto: update rustcrypto deps Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.61%. Comparing base (8ef7951) to head (0173a2f).

Files with missing lines Patch % Lines
crates/bitwarden-crypto/src/keys/master_key.rs 16.66% 5 Missing ⚠️
crates/bitwarden-core/src/auth/key_connector.rs 0.00% 2 Missing ⚠️
crates/bitwarden-core/src/auth/auth_client.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
- Coverage   78.70%   78.61%   -0.09%     
==========================================
  Files         296      296              
  Lines       30500    30476      -24     
==========================================
- Hits        24005    23959      -46     
- Misses       6495     6517      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants