Skip to content

Commit fa3c657

Browse files
author
MarcoFalke
committed
lint: Add false positive to python dead code linter
1 parent fa25668 commit fa3c657

File tree

3 files changed

+50
-5
lines changed

3 files changed

+50
-5
lines changed

.travis/lint_04_install.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66

77
export LC_ALL=C
88

9-
travis_retry pip install codespell==1.15.0
10-
travis_retry pip install flake8==3.5.0
11-
travis_retry pip install vulture==0.29
9+
travis_retry pip3 install codespell==1.15.0
10+
travis_retry pip3 install flake8==3.5.0
11+
travis_retry pip3 install vulture==0.29
1212

1313
SHELLCHECK_VERSION=v0.6.0
1414
curl -s "https://storage.googleapis.com/shellcheck/shellcheck-${SHELLCHECK_VERSION}.linux.x86_64.tar.xz" | tar --xz -xf - --directory /tmp/
Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
BadInputOutpointIndex # unused class (test/functional/data/invalid_txs.py)
2+
_.carbon_path # unused attribute (contrib/macdeploy/custom_dsstore.py)
3+
connection_lost # unused function (test/functional/test_framework/mininode.py)
4+
connection_made # unused function (test/functional/test_framework/mininode.py)
5+
_.converter # unused attribute (test/functional/test_framework/test_framework.py)
6+
_.daemon # unused attribute (test/functional/test_framework/socks5.py)
7+
data_received # unused function (test/functional/test_framework/mininode.py)
8+
DuplicateInput # unused class (test/functional/data/invalid_txs.py)
9+
_.filename # unused attribute (contrib/macdeploy/custom_dsstore.py)
10+
InvalidOPIFConstruction # unused class (test/functional/data/invalid_txs.py)
11+
_.is_compressed # unused property (test/functional/test_framework/key.py)
12+
legacy # unused variable (test/functional/test_framework/address.py)
13+
msg_generic # unused class (test/functional/test_framework/messages.py)
14+
NonexistentInput # unused class (test/functional/data/invalid_txs.py)
15+
on_addr # unused function (test/functional/test_framework/mininode.py)
16+
on_blocktxn # unused function (test/functional/test_framework/mininode.py)
17+
on_block # unused function (test/functional/test_framework/mininode.py)
18+
on_cmpctblock # unused function (test/functional/test_framework/mininode.py)
19+
on_feefilter # unused function (test/functional/test_framework/mininode.py)
20+
on_getaddr # unused function (test/functional/test_framework/mininode.py)
21+
on_getblocks # unused function (test/functional/test_framework/mininode.py)
22+
on_getblocktxn # unused function (test/functional/test_framework/mininode.py)
23+
on_getdata # unused function (test/functional/test_framework/mininode.py)
24+
on_getheaders # unused function (test/functional/test_framework/mininode.py)
25+
on_headers # unused function (test/functional/test_framework/mininode.py)
26+
on_inv # unused function (test/functional/test_framework/mininode.py)
27+
on_mempool # unused function (test/functional/test_framework/mininode.py)
28+
on_notfound # unused function (test/functional/test_framework/mininode.py)
29+
on_ping # unused function (test/functional/test_framework/mininode.py)
30+
on_pong # unused function (test/functional/test_framework/mininode.py)
31+
on_reject # unused function (test/functional/test_framework/mininode.py)
32+
on_sendcmpct # unused function (test/functional/test_framework/mininode.py)
33+
on_sendheaders # unused function (test/functional/test_framework/mininode.py)
34+
on_tx # unused function (test/functional/test_framework/mininode.py)
35+
on_verack # unused function (test/functional/test_framework/mininode.py)
36+
on_version # unused function (test/functional/test_framework/mininode.py)
37+
_.optionxform # unused attribute (test/util/bitcoin-util-test.py)
38+
OutputMissing # unused class (test/functional/data/invalid_txs.py)
39+
_.posix_path # unused attribute (contrib/macdeploy/custom_dsstore.py)
40+
profile_with_perf # unused function (test/functional/test_framework/test_node.py)
41+
SizeTooSmall # unused class (test/functional/data/invalid_txs.py)
42+
SpendNegative # unused class (test/functional/data/invalid_txs.py)
43+
SpendTooMuch # unused class (test/functional/data/invalid_txs.py)
44+
TooManySigops # unused class (test/functional/data/invalid_txs.py)
45+
verify_ecdsa # unused function (test/functional/test_framework/key.py)

test/lint/lint-python-dead-code.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ fi
1515

1616
vulture \
1717
--min-confidence 60 \
18-
--ignore-names "argtypes,connection_lost,connection_made,converter,data_received,daemon,errcheck,is_compressed,is_valid,verify_ecdsa,msg_generic,on_*,optionxform,restype,profile_with_perf" \
19-
$(git ls-files -- "*.py" ":(exclude)contrib/" ":(exclude)test/functional/data/invalid_txs.py")
18+
$(git rev-parse --show-toplevel) \
19+
$(dirname "${BASH_SOURCE[0]}")/lint-python-dead-code-whitelist

0 commit comments

Comments
 (0)