[node-tracing] Remove dead serverId/serverToken config

Author: romainneutron

README.md

@@ -45,6 +45,8 @@ Blackfire.start({
 // Blackfire.stop();
 ```
 
+Authentication is handled by the Blackfire Agent, not the probe: the agent forwards profiles to the backend using its own credentials (`BLACKFIRE_SERVER_ID` / `BLACKFIRE_SERVER_TOKEN` configured on the agent). The probe only needs to reach the agent socket.
+
 ## Example
 
 1. Install dependencies

src/index.d.ts

@@ -3,10 +3,6 @@ export interface BlackfireConfiguration {
   appName?: string;
   /** Socket to the Blackfire agent. Defaults to platform-specific socket. */
   agentSocket?: string;
-  /** Blackfire Server ID (should be defined with serverToken). */
-  serverId?: string;
-  /** Blackfire Server Token (should be defined with serverId). */
-  serverToken?: string;
   /** Labels to add to the profile. */
   labels?: Record<string, string>;
   /** Timeout in milliseconds for the upload request. Defaults to 10000. */
@@ -18,5 +14,4 @@ export function stop(): boolean;
 
 export const defaultConfig: Required<
   Pick<BlackfireConfiguration, 'appName' | 'agentSocket' | 'uploadTimeoutMillis' | 'labels'>
-> &
-  Pick<BlackfireConfiguration, 'serverId' | 'serverToken'>;
+>;

src/index.js

@@ -71,10 +71,6 @@ const defaultConfig = {
   appName: 'my-node-app',
   /** socket to the Blackfire agent. */
   agentSocket: process.env.BLACKFIRE_AGENT_SOCKET || defaultAgentSocket(),
-  /** Blackfire Server ID (should be defined with serverToken). */
-  serverId: undefined,
-  /** Blackfire Server Token (should be defined with serverId). */
-  serverToken: undefined,
   /** Labels to add to the profile. */
   labels: {},
   /** Timeout in milliseconds for the upload request. */

src/index.test-d.ts

@@ -8,8 +8,6 @@ expectType<boolean>(start({ appName: 'my-app' }));
 expectType<boolean>(start({
   appName: 'my-app',
   agentSocket: 'tcp://127.0.0.1:8307',
-  serverId: 'server-id',
-  serverToken: 'server-token',
   labels: { env: 'production' },
   uploadTimeoutMillis: 5000,
 }));

tests/index.test.js

@@ -8,9 +8,7 @@ test('Blackfire imports', () => {
 
   expect(Blackfire.defaultConfig).toHaveProperty('appName');
   expect(Blackfire.defaultConfig).toHaveProperty('agentSocket');
-  expect(Blackfire.defaultConfig).toHaveProperty('serverId');
-  expect(Blackfire.defaultConfig).toHaveProperty('serverToken');
   expect(Blackfire.defaultConfig).toHaveProperty('uploadTimeoutMillis');
   expect(Blackfire.defaultConfig).toHaveProperty('labels');
-  expect(Object.keys(Blackfire.defaultConfig)).toHaveLength(6);
+  expect(Object.keys(Blackfire.defaultConfig)).toHaveLength(4);
 });