Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created kubernetes contiv container should be able to be created and tagged by SHA #36

Open
blaksmit opened this issue Nov 8, 2017 · 3 comments

Comments

@blaksmit
Copy link
Owner

blaksmit commented Nov 8, 2017

#31

Much like v2plugin and netplugin binary tarball, netplugin artifacts for k8s container should be differentiated by SHA and available through dockerd so the contiv installer can execute the netplugin build for the container against any branch, which allows testing of any PR in CI

[CNTV-183] created by chris.plock
@blaksmit
Copy link
Owner Author

blaksmit commented Nov 9, 2017

What is this about? This is pretty vague. It doesn't say what's the issue and what's needed exactly.

There's no such kubernetes container. There's only a generic netplugin Docker image.

by rstaretu

@blaksmit
Copy link
Owner Author

blaksmit commented Nov 9, 2017

the linked ticket GH-26 Open is the driver for this ticket. I think the netplugin docker image is probably the "netplugin artifact" that is needed, I can flesh the ticket out more when my focus can shift to this ticket and I've spent a little time with a k8s cluster.

by chris.plock

@blaksmit
Copy link
Owner Author

netplugin/vagrant/k8s/Vagrantfile grabs netctl from a downloaded release version, that needs updating
install/k8s/contiv/contiv.yaml, contiv_devtest.yaml, and contiv_aci.yaml need to be updated to support passing in the container name, and need to make sure it's pulling from local dockerd
we'll need to build the container and push it based on branch build

I'm not sure how CI is getting the right container yet

by chris.plock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant