Skip to content

Commit 39263e1

Browse files
committed
build: replace sed sanitize with Go build tags
1 parent 346c366 commit 39263e1

4 files changed

Lines changed: 14 additions & 18 deletions

File tree

Makefile

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -52,30 +52,18 @@ prepare:
5252
@mkdir -p build
5353

5454

55-
SED_IN_PLACE = sed -i ''
56-
ifeq ($(OS), linux)
57-
SED_IN_PLACE = sed -i
58-
endif
59-
60-
release_logging = $(SED_IN_PLACE) 's/LoggingMode = .*/LoggingMode = Release/' pkg/logging/log.go
61-
62-
6355
.PHONY: build
6456
build: $(foreach target,$(TARGETS),build/$(target))
6557

6658

67-
.PHONY: sanitize
68-
sanitize:
69-
$(call release_logging)
70-
71-
7259
build/%: $(BROWSER_DEFS) $(SRC)
7360
$(GOBUILD) -tags "$(TAGS)" -o build/$* $(BUILD_FLAGS) ./cmd/$*
7461

7562

7663
.PHONY: release
64+
release: TAGS += release
7765
release: BUILD_FLAGS = $(RELEASE_LDFLAGS)
78-
release: sanitize build
66+
release: build
7967

8068

8169
.PHONY: debug

pkg/logging/log.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,8 @@ const (
7575
)
7676

7777
var (
78-
//RELEASE: Change to Release for release mode
79-
LoggingMode = Dev
80-
TUIMode bool
81-
SilentMode bool
78+
TUIMode bool
79+
SilentMode bool
8280
)
8381

8482
var (

pkg/logging/log_mode_dev.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
//go:build !release
2+
3+
package logging
4+
5+
var LoggingMode = Dev

pkg/logging/log_mode_release.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
//go:build release
2+
3+
package logging
4+
5+
var LoggingMode = Release

0 commit comments

Comments
 (0)