Consolidate configuration/logging locations #1049
Assignees
Labels
enhancement
New feature or request
Comments
jasonkneen
added a commit
to jasonkneen/maverick
that referenced
this issue
Feb 6, 2025
Fixes block#1049 Consolidate configuration and logging locations to use the `etcetera` crate. * **Cargo.toml** - Add `etcetera` crate to `[dependencies]` section. * **crates/goose-cli/src/log_usage.rs** - Replace `dirs::home_dir()` with `etcetera::base_strategy::get_config_dir()`. - Update log directory path to use `etcetera`. * **crates/goose-server/src/logging.rs** - Replace `std::env::var("HOME")` with `etcetera::base_strategy::get_config_dir()`. - Update log directory path to use `etcetera`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/block/goose/issues/1049?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consolidate configuration & logging locations
Various crates use / hard code
$HOME/.configas the location to store various configuration/output files, and using different approaches to resolve$HOMEdirs::home_dir()$HOMEand joining the pathWe should consolidate on a single approach, and ensure whatever approach we take supports other OSs (windows, etc).
The XDG spec could be something an option to follow: https://specifications.freedesktop.org/basedir-spec/latest/.
We currently put the logs in
~/.config/goose/logswhich imo should go somewhere else (maybe$HOME/.local/state/goose?)I know the mac developer guide recommends things like
~/Library/Application Support(see MOSXAppProgrammingGuide an older guide but seems to still be relevant) , but I do like the~/.configfor MacOS personally, even more from a CLI perspective.A couple crates we can evaluate:
etceteraseems to be the most popular, and can support the platforms we want, while enforcing xdg on macos.The text was updated successfully, but these errors were encountered: