-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool result must be preceeded by a tool call #1056
Labels
bug
Something isn't working
Comments
orginally posted in discord: https://discord.com/channels/1287729918100246654/1334153060447944789/1334164125688791074 |
jasonkneen
added a commit
to jasonkneen/maverick
that referenced
this issue
Feb 5, 2025
Fixes block#1056 Add checks to ensure tool results are always preceded by tool calls. * **`crates/goose/src/agents/reference.rs`** - Add a check in the `reply` function to ensure tool results are always preceded by tool calls. * **`crates/goose/src/agents/truncate.rs`** - Add a check in the `reply` function to ensure tool results are always preceded by tool calls. * **`crates/goose/src/message.rs`** - Add a method to the `Message` struct to enforce the order of tool calls and results. * **`crates/goose-cli/src/prompt/renderer.rs`** - Add a check in the `render` function to ensure the order of tool requests and responses. - Print an error message if the tool result is not preceded by a tool call. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/block/goose/issues/1056?shareId=XXXX-XXXX-XXXX-XXXX).
Closed
We've seen this before and it is related to the state management in useChat. There are likely some edge cases still remaining. This fixed one class of errors for example #859 |
ShinnosukeKomiya
added a commit
to ShinnosukeKomiya/goose_quick_start
that referenced
this issue
Feb 11, 2025
block/goose#1056 のようなissueが発生する
ShinnosukeKomiya
added a commit
to ShinnosukeKomiya/goose_quick_start
that referenced
this issue
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
tool result must be preceeded by a tool call
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
![Image](https://private-user-images.githubusercontent.com/7154255/409304317-ddebb7ec-18df-47dc-a552-c3d602e5c26f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNjUxMDQsIm5iZiI6MTczOTI2NDgwNCwicGF0aCI6Ii83MTU0MjU1LzQwOTMwNDMxNy1kZGViYjdlYy0xOGRmLTQ3ZGMtYTU1Mi1jM2Q2MDJlNWMyNmYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTFUMDkwNjQ0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODM2Nzk1MDQwOGFiY2ZmZTUxYWI3MDZhZDU3ZjRkZWJjOTkwNjhjYmRkYzQwZGM4Y2M5ZDY1YzM3ZTllMzgxMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.oaqJFpFUoJ9J-eJL_B22I8JbElVVncrmuMTroYpxxS4)
Please provide following information:
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: