Fix tool result order #1087
Closed
Fix tool result order #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes block#1056 Add checks to ensure tool results are always preceded by tool calls. * **`crates/goose/src/agents/reference.rs`** - Add a check in the `reply` function to ensure tool results are always preceded by tool calls. * **`crates/goose/src/agents/truncate.rs`** - Add a check in the `reply` function to ensure tool results are always preceded by tool calls. * **`crates/goose/src/message.rs`** - Add a method to the `Message` struct to enforce the order of tool calls and results. * **`crates/goose-cli/src/prompt/renderer.rs`** - Add a check in the `render` function to ensure the order of tool requests and responses. - Print an error message if the tool result is not preceded by a tool call. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/block/goose/issues/1056?shareId=XXXX-XXXX-XXXX-XXXX).
|
autogenerated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1056
Add checks to ensure tool results are always preceded by tool calls.
crates/goose/src/agents/reference.rsreplyfunction to ensure tool results are always preceded by tool calls.crates/goose/src/agents/truncate.rsreplyfunction to ensure tool results are always preceded by tool calls.crates/goose/src/message.rsMessagestruct to enforce the order of tool calls and results.crates/goose-cli/src/prompt/renderer.rsrenderfunction to ensure the order of tool requests and responses.For more details, open the Copilot Workspace session.