Skip to content

Commit 51d0cb8

Browse files
committed
Yet another attempt to pickup proper node version
1 parent 8ff0988 commit 51d0cb8

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

Dockerfile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
ARG VARIANT="1.17.3-erlang-27.1-debian-bullseye-20240926"
2-
ARG PHOENIX_VERSION="1.7.10"
3-
ARG NODEJS_VERSION="18"
42
FROM hexpm/elixir:${VARIANT}
53

4+
ARG PHOENIX_VERSION="1.7.10"
5+
ARG NODE_VERSION="18"
6+
67
# This Dockerfile adds a non-root user with sudo access. Update the “remoteUser” property in
78
# devcontainer.json to use it. More info: https://aka.ms/vscode-remote/containers/non-root-user.
89
ARG USERNAME=vscode
@@ -31,10 +32,10 @@ RUN apt-get update \
3132
&& /bin/bash /tmp/common-setup.sh "${INSTALL_ZSH}" "${USERNAME}" "${USER_UID}" "${USER_GID}" "${UPGRADE_PACKAGES}" \
3233
#
3334
# [Optional] Install Node.js for use with web applications
34-
&& if [ "${NODEJS_VERSION}" != "none" ]; then \
35+
&& if [ "${NODE_VERSION}" != "none" ]; then \
3536
curl -sSL ${NODE_SCRIPT_SOURCE} -o /tmp/node-setup.sh \
3637
&& ([ "${NODE_SCRIPT_SHA}" = "dev-mode" ] || (echo "${NODE_SCRIPT_SHA} */tmp/node-setup.sh" | sha256sum -c -)) \
37-
&& /bin/bash /tmp/node-setup.sh "${NVM_DIR}" "${NODEJS_VERSION}" "${USERNAME}" \
38+
&& /bin/bash /tmp/node-setup.sh "${NVM_DIR}" "${NODE_VERSION}" "${USERNAME}" \
3839
&& npm install -g cspell@latest; \
3940
fi \
4041
#

0 commit comments

Comments
 (0)