Make snapshot the default txn mode

Signed-off-by: mdouglas47 <[email protected]>

Author: morgando

db/comdb2.c

@@ -448,8 +448,8 @@ int gbl_goslow = 0; /* set to disable "gofast" */
 
 int gbl_selectv_rangechk = 0; /* disable selectv range check by default */
 
-int gbl_sql_tranlevel_preserved = SQL_TDEF_SOCK;
-int gbl_sql_tranlevel_default = SQL_TDEF_SOCK;
+int gbl_sql_tranlevel_preserved = SQL_TDEF_SNAPISOL;
+int gbl_sql_tranlevel_default = SQL_TDEF_SNAPISOL;
 int gbl_exit_alarm_sec = 300;
 int gbl_test_blkseq_replay_code = 0;
 int gbl_dump_blkseq = 0;
@@ -460,8 +460,8 @@ int gbl_disable_overflow_page_trace = 1;
 int gbl_simulate_rowlock_deadlock_interval = 0;
 int gbl_enable_berkdb_retry_deadlock_bias = 0;
 int gbl_enable_cache_internal_nodes = 1;
-int gbl_use_modsnap_for_snapshot = 0;
-int gbl_modsnap_asof = 0;
+int gbl_use_modsnap_for_snapshot = 1;
+int gbl_modsnap_asof = 1;
 int gbl_rep_process_txn_time = 0;
 int gbl_utxnid_log = 1;
 int gbl_test_commit_lsn_map = 0;
@@ -532,7 +532,7 @@ int gbl_rowlocks = 0;
 int gbl_disable_tagged_api = 1;
 int gbl_disable_tagged_api_writes = 1;
 int gbl_serializable = 0; // Just for bookkeeping
-int gbl_snapisol = 0;
+int gbl_snapisol = 1;
 int gbl_new_snapisol = 0;
 int gbl_new_snapisol_asof = 0;
 int gbl_new_snapisol_logging = 0;

db/sqlglue.c

@@ -3818,7 +3818,7 @@ int sqlite3BtreeOpen(
     return rc;
 }
 
-static char *tranlevel_toclntstr(int lvl)
+char *tranlevel_toclntstr(int lvl)
 {
     switch (lvl) {
     case TRANLEVEL_SOSQL:

lua/sp.c

@@ -88,6 +88,8 @@ extern int gbl_allow_lua_print;
 extern int gbl_lua_prepare_max_retries;
 extern int gbl_lua_prepare_retry_sleep;
 
+extern char *tranlevel_toclntstr(int lvl);
+
 pthread_t gbl_break_lua;
 int gbl_break_all_lua = 0;
 char *gbl_break_spname;
@@ -4788,7 +4790,7 @@ static int register_queue_with_berkdb_and_master(Lua L, const char *type)
         return luaL_error(L, "attempt to run consumer in child thread");
     }
     if (clnt->dbtran.mode != TRANLEVEL_SOSQL) {
-        return luaL_error(L, "%s is only supported under default transaction mode", type);
+        return luaL_error(L, "%s is only supported under %s transaction mode", type, tranlevel_toclntstr(TRANLEVEL_SOSQL));
     }
 
     dbconsumer_t *consumer;
@@ -7296,6 +7298,11 @@ static int exec_procedure_int(struct sqlthdstate *thd,
         return SQLITE_ACCESS;
     }
 
+    const int convert_modsnap_to_sosql = sp->can_consume && !clnt->in_client_trans && clnt->dbtran.mode == TRANLEVEL_MODSNAP;
+    if (convert_modsnap_to_sosql) {
+        clnt->dbtran.mode = TRANLEVEL_SOSQL;
+    }
+
     if (gbl_is_physical_replicant && consumer) {
         rc = -3;
         (*err) = strdup("Cannot execute consumer on physical-replicant");
@@ -7304,6 +7311,10 @@ static int exec_procedure_int(struct sqlthdstate *thd,
         rc = push_args_and_run_sp(clnt, end_ptr, err);
     }
 
+    if (convert_modsnap_to_sosql) {
+        clnt->dbtran.mode = TRANLEVEL_MODSNAP;
+    }
+
     if (trigger) {
         return rc;
     }

plugins/newsql/newsql.c

@@ -2410,7 +2410,7 @@ newsql_loop_result newsql_loop(struct sqlclntstate *clnt, CDB2SQLQUERY *sql_quer
         clnt->ctrl_sqlengine = SQLENG_NORMAL_PROCESS;
     }
     if (clnt->dbtran.mode < TRANLEVEL_SOSQL) {
-        clnt->dbtran.mode = TRANLEVEL_SOSQL;
+        clnt->dbtran.mode = TRANLEVEL_MODSNAP;
     }
     clnt->osql.sent_column_data = 0;