Fix typos and closure that wasn't a closure #1097
Conversation
| } | ||
| myFunction(); | ||
| const closureFunction = myFunction(); | ||
| closureFunction(); |
There was a problem hiding this comment.
Both versions of the code seem to work. This exercise deals in lexical scoping. Do you think the changes proposed make the rules of visibility clearer? Is this what you refer to as the "closure that wasn't"?
There was a problem hiding this comment.
So........ The problem is a bit hard to explain. Yes the function works and yes it can access the lexical scope but it's not a closure like it states above.
It can access it because was declared first. not because its a closure.
There was a problem hiding this comment.
All functions in JS are closures! They all "remember" the bindings in the environment they were defined in, even when that environment has gone away (returned). Your version makes the "even" part super explicit. Let's come up with another name for "closureFunction"! This way we don't give ideas that closures have to be built "just so". Something that makes the point that "closureFunction" points exactly to "nestedFunction". Can you think of anything? Something like "nestedFunctionAlso"? Mh. I don't like that...
There was a problem hiding this comment.
What I mean is that the current function works because internal is declared before nestedFunction so its a normal variable being declared before a normal function. If we had a counter inside it would not increment because it would not keep a reference to it in memory.
This is what I mean: https://stackoverflow.com/a/35130876/1368742
The current function is just a "function with free variables".
| @@ -8,14 +8,14 @@ | |||
|
|
|||
|
|
|||
| /* == Step 2: Volume Method == | |||
| Create a method using CuboidMaker's prototype that returns the volume of a given cuboid's length, width, and height | |||
| Create a method named volume using CuboidMaker's prototype that returns the volume of a given cuboid's length, width, and height | |||
I'd like to have this PR accepted, it fixes a few typos and wrong code.
Should close #1009