use of assert in non-test methods

[kivel]

It appears that assert is used in core methods.

Why is this problematic?

From the documentation it becomes clear that this code is only executed when debugging is enabled.
When executed with the -O argument, assert statements are typically completely disabled.

fix

replace assert with proper check + exceptions.

[coretl]

Personally I have always used assert for things that really shouldn't ever fail, like:

ophyd-async/src/ophyd_async/core/_device.py

Line 185 in 4f4458c

assert self._connect_task, "Connect task not created, this shouldn't happen"

In this case the logic will always set self._connect_task, but the conditionals are too complicated for the type checker to infer this. The assert statement is then really for the benefit of the type checker. I seem to have picked up this habit from the mypy cheat sheet. Would you rewrite this statement with a check and raise?

[kivel]

Yes, I would rewrite those as check and raise.
I'd enable S101, to ensure assert isn't used.

[coretl]

Fixed by #728