-
-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Filters on Uptime Monitors Page #1990
Comments
CC @gorkem-bwl, @ajhollid |
Sharing my first draft of filters implementation. (Reset button yet to be created) |
Looks like a good start to me. You can play with the colors + remove the line widget explanation area (where it says "Type") later on. Also you can check whether the drop down menu line heights are the same with the ones in the components. |
Filter.mp4@ajhollid @gorkem-bwl, need to clarify one thing. since down monitors also have the field isActive as true only their |
Yep, I am good with that. You might also think about right-aligning all the UI related elements added here. |
Near to the search component? |
Yes for both :) |
@gorkem-bwl @Br0wnHammer monitors have two properties that we likelty want to filter by Whether or not a monitor is "Up" or "Down" depends on the Whether or not a monitor is "Paused" or "Not Paused" depends on the I don't know if users will equat "Active" and "Inactive" to "Paued" and "Not Paused". I would suggest the filter values be "Up" / "Down" -> That would be the most intiuitive to me. |
How about: Status: Up or Down ? |
Just to clarify, the three filters would now be: ? |
Yes, plus the search section. All will be connected with "AND". |
@gorkem-bwl, I had a chat with Alex regarding search section. He believes better to leave the search component alone for now for the first stage. |
I am good with that 👍 |
Filter.mp4Hey @gorkem-bwl, @ajhollid, please review the filtering functionality. Also, please mention any UI improvements. |
Light theme looks good. |
Hey @gorkem-bwl, final UI. |
Looks good to me ! |
Is your feature request related to a problem? Please describe.
We need to implement filtering on the uptime monitors page. This is the first stage of the filter implementation.
Describe the solution you'd like
Filters to Implement (Stage 1)
Type:
http
,port
,docker
,ping
Status:
Resumed
,Paused
Have a reset button present when a filter is selected.
Backend Status
✅ Mostly, the required DB queries are completed.
Frontend Requirements
Use the
Chip
component to handle filters effectively.Ensure that filtering is smooth and intuitive.
Debounce search queries
when filtering via string input, so we are not making a query for every keystroke.Tasks
The text was updated successfully, but these errors were encountered: