From a15c49c2fa0a7800da0a32fcdde398884dd6461c Mon Sep 17 00:00:00 2001 From: Kevin Ness Date: Mon, 22 Apr 2024 21:15:50 -0400 Subject: [PATCH 1/2] Filter out empty suite results for version --- .../components/SuiteSelector/index.tsx | 7 ++++++- src/components/conformance/ResultsDisplay/nav.tsx | 15 ++++++++++----- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx b/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx index bf327525..706aeef7 100644 --- a/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx +++ b/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx @@ -1,5 +1,5 @@ import React from "react"; -import { SuiteResult } from "@site/src/components/conformance/types"; +import { SuiteResult, TestStats } from "@site/src/components/conformance/types"; import styles from "./styles.module.css"; @@ -14,7 +14,12 @@ export default function SuiteSelector(props: SelectorProps): JSX.Element {
{props.suites .sort((a, b) => a.name.localeCompare(b.name)) + .filter((suite) => { + let versionStats: TestStats = suite.versionedStats[props.esFlag]; + return versionStats.total !== 0; + }) .map((suite) => { + console.log(`${suite.name}:`, suite); return ( - + { - setDropdownValue(props.esVersionValue) - }, [props.esVersionValue]) + React.useEffect(() => { + setDropdownValue(props.esVersionValue); + }, [props.esVersionValue]); const handleVersionSelection = (e) => { // Update the display value and set the flag. From cce58e3466eecd786d33faa29e7648672af03c0a Mon Sep 17 00:00:00 2001 From: Kevin Ness Date: Mon, 22 Apr 2024 21:33:05 -0400 Subject: [PATCH 2/2] Remove a console log --- .../ResultsDisplay/components/SuiteSelector/index.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx b/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx index 706aeef7..76613f00 100644 --- a/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx +++ b/src/components/conformance/ResultsDisplay/components/SuiteSelector/index.tsx @@ -19,7 +19,6 @@ export default function SuiteSelector(props: SelectorProps): JSX.Element { return versionStats.total !== 0; }) .map((suite) => { - console.log(`${suite.name}:`, suite); return (