Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement total method for Duration #139

Closed
nekevss opened this issue Dec 23, 2024 · 0 comments · Fixed by #241
Closed

Implement total method for Duration #139

nekevss opened this issue Dec 23, 2024 · 0 comments · Fixed by #241
Labels
C-enhancement New feature or request
Milestone
0.1 Blocking

Comments

@nekevss
Copy link
Member

nekevss commented Dec 23, 2024 •
edited
Loading

Per the Temporal specification, Duration needs to have a Duration::total method implemented.

This is related to ongoing progress for #11
@nekevss nekevss added the C-enhancement New feature or request label Jan 7, 2025
@nekevss nekevss added this to the 0.1 Blocking milestone Mar 3, 2025
@lockels lockels mentioned this issue Mar 8, 2025
Merged
sebastianjacmatt pushed a commit to sebastianjacmatt/temporal that referenced this issue Mar 17, 2025
@lockels @sebastianjacmatt
Initial implementation of Duration.prototype.total (boa-dev#241)
07be388 
Fixes boa-dev#139 

Tests adapted from sample code in
https://tc39.es/proposal-temporal/docs/duration.html under total now
pass :)

I have a question in duration.rs about return types!

There's also another question in normalized.rs regarding some code i'd
like to refactor that makes this PR quite a bit larger than it needs to
be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement New feature or request
Projects
None yet
Milestone
0.1 Blocking
Development

Successfully merging a pull request may close this issue.

Initial implementation of Duration.prototype.total lockels/temporal
1 participant
@nekevss