Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ToZonedDateTime method for PlainDate #148

Open
nekevss opened this issue Jan 7, 2025 · 3 comments
Open

Implement ToZonedDateTime method for PlainDate #148

nekevss opened this issue Jan 7, 2025 · 3 comments
Assignees
@Magnus-Fjeldstad @JohannesHelleve
Labels
C-enhancement New feature or request E-easy Easy issue to fix - Good for newcomers Good First Issue
Milestone
0.1 Blocking

Comments

@nekevss
Copy link
Member

nekevss commented Jan 7, 2025

Related to ongoing work for #7.

The ToZonedDateTime method needs to be implemented on PlainDate.
@nekevss nekevss added E-easy Easy issue to fix - Good for newcomers C-enhancement New feature or request labels Jan 7, 2025
@JohannesHelleve JohannesHelleve mentioned this issue Feb 12, 2025
Open
@nekevss nekevss added this to the 0.1 Blocking milestone Mar 3, 2025
@Magnus-Fjeldstad
Copy link
Contributor

Is this issue still relevent? I feel like it was solved in #149 If not i want to work on this.

@nekevss
Copy link
Member Author

nekevss commented Mar 18, 2025

There is currently an open PR (#192) that could maybe be helped with. I'm not entirely clear on the current state of the PR.

To note, #149 was for the implementation on PlainDateTime, not PlainDate. So that is the reason this issue is still open.

@JohannesHelleve
Copy link

@Magnus-Fjeldstad you can help me in the pr if you would like, im little bit stuck. And have not been able to contribute due to some private issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Magnus-Fjeldstad Magnus-Fjeldstad

@JohannesHelleve JohannesHelleve

Labels
C-enhancement New feature or request E-easy Easy issue to fix - Good for newcomers Good First Issue
Projects
None yet
Milestone
0.1 Blocking
Development

No branches or pull requests
3 participants
@nekevss @Magnus-Fjeldstad @JohannesHelleve