Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.a files ends up in osx dir #58

Closed
clemens-tolboom opened this issue Feb 15, 2021 · 7 comments
Closed

.a files ends up in osx dir #58

clemens-tolboom opened this issue Feb 15, 2021 · 7 comments
Labels
build-release Related to the build and release pipeline.

Comments

@clemens-tolboom
Copy link
Contributor

scons target=release osgeo_path=/usr/local/Cellar/gdal/3.2.1

find demo/addons/geodot/osx/
demo/addons/geodot/osx/
demo/addons/geodot/osx//libRasterTileExtractor.a <==================
demo/addons/geodot/osx//libgeodot.dylib
demo/addons/geodot/osx//libVectorExtractor.a <===============

This is caused by 538e2b3 somehow.

It is a little weird as libgeodot.dylib is created OK

@clemens-tolboom
Copy link
Contributor Author

Root cause is we don't have one SConstruct but three. Can we please just have one!

That would prevent future issues like #38 + #43

@kb173
Copy link
Member

kb173 commented Feb 15, 2021

They are explicitly copied at the end of the SConstruct script. However, I rebuilt these libraries to be static, and you're right, it seems like there's actually no need for that copy now.

@kb173 kb173 added the build-release Related to the build and release pipeline. label Feb 15, 2021
@clemens-tolboom
Copy link
Contributor Author

.so is shared, .a is static

@kb173
Copy link
Member

kb173 commented Feb 15, 2021

Seems like there may be mac-specific problems with this (further discussion on that in #57), but the .a files were removed from the addon directory in 11c3b21 because that's how it should work (and it does on Linux) - so this can be closed.

@kb173 kb173 closed this as completed Feb 15, 2021
@clemens-tolboom
Copy link
Contributor Author

Not sure I agree as in #57 only the .dylib version works so I want/need that back right?

@kb173
Copy link
Member

kb173 commented Feb 15, 2021

I'd prefer getting the static library (the .a) to work on Mac OS. Not sure what's wrong with it - since it works on Windows and Linux, I'm guessing we're missing some linker flag or something...

@clemens-tolboom
Copy link
Contributor Author

I should have linked to #57 (comment) regarding MacOS failing on .a file extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-release Related to the build and release pipeline.
Projects
None yet
Development

No branches or pull requests

2 participants