Skip to content

Commit 6d312af

Browse files
authored
chore!: deprecate any_color_converted_view (#678)
color_converted_view has the same implementation and can be used as a replacement, providing the same functionality. This builds on #660 by @marco-langer (Thank you!) Due to the fact that the switch to C++14 has been announced in #677, we can now officially use the [[deprecated]] attribute which was standardized in C++14. This is initial part of deprecating the `any_color_converted_view` and as @marco-langer pointed in #660 (comment) there are more changes to follow.
1 parent dcae92f commit 6d312af

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

RELEASES.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
2626
Currently, large parts of GIL still compile with a C++11 compiler. However,
2727
there is no guarantee that it stays that way, and any compilers that do not
2828
support at least C++14 are considered unsupported as of now.
29+
- BREAKING: `any_color_converted_view()` is deprecated and will be removed in the next release.
30+
Use `color_converted_view()` instead, which provides the same feature.
2931
- documentation: Display that GIL is a header-only library
3032
- Moved numeric extension to core ([PR #573](https://github.com/boostorg/gil/pull/573))
3133
- Added support for C++17's `<filesystem>` ([PR #636](https://github.com/boostorg/gil/pull/636)).

include/boost/gil/extension/dynamic_image/image_view_factory.hpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -379,6 +379,7 @@ auto color_converted_view(any_image_view<Views...> const& src)
379379
/// These are workarounds for GCC 3.4, which thinks color_converted_view is ambiguous with the same method for templated views (in gil/image_view_factory.hpp)
380380
/// \tparam Views Models Boost.MP11-compatible list of models of ImageViewConcept
381381
template <typename DstP, typename ...Views, typename CC>
382+
[[deprecated("Use color_converted_view(const any_image_view<Views...>& src, CC) instead.")]]
382383
inline
383384
auto any_color_converted_view(const any_image_view<Views...>& src, CC)
384385
-> typename color_converted_view_type<any_image_view<Views...>, DstP, CC>::type
@@ -392,6 +393,7 @@ auto any_color_converted_view(const any_image_view<Views...>& src, CC)
392393
/// These are workarounds for GCC 3.4, which thinks color_converted_view is ambiguous with the same method for templated views (in gil/image_view_factory.hpp)
393394
/// \tparam Views Models Boost.MP11-compatible list of models of ImageViewConcept
394395
template <typename DstP, typename ...Views>
396+
[[deprecated("Use color_converted_view(any_image_view<Views...> const& src) instead.")]]
395397
inline
396398
auto any_color_converted_view(const any_image_view<Views...>& src)
397399
-> typename color_converted_view_type<any_image_view<Views...>, DstP>::type

0 commit comments

Comments
 (0)