From e783612fbf8a289d267fbe150d65ebf7bae34a7a Mon Sep 17 00:00:00 2001 From: Becojo Date: Fri, 3 May 2024 15:11:58 -0400 Subject: [PATCH 1/2] fix test --- opa/opa_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/opa/opa_test.go b/opa/opa_test.go index 5ca7d5e..9f8979c 100644 --- a/opa/opa_test.go +++ b/opa/opa_test.go @@ -67,7 +67,7 @@ func TestSemverConstraintCheck(t *testing.T) { { constraint: ">=4.0.0,<4.4.1", version: "4", - expected: true, + expected: false, }, { constraint: ">=4.0.0,<4.4.1", @@ -84,7 +84,7 @@ func TestSemverConstraintCheck(t *testing.T) { err := opa.Eval(context.TODO(), "semver.constraint_check(\""+c.constraint+"\", \""+c.version+"\")", nil, &result) noOpaErrors(t, err) - assert.Equal(t, c.expected, result) + assert.Equal(t, c.expected, result, "constraint: "+c.constraint+" version: "+c.version) } } From 3ee3f1657e60d15d6c28333434995aff71535726 Mon Sep 17 00:00:00 2001 From: Becojo Date: Fri, 3 May 2024 15:48:29 -0400 Subject: [PATCH 2/2] ish --- opa/builtins.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/opa/builtins.go b/opa/builtins.go index 913a8ab..20e4180 100644 --- a/opa/builtins.go +++ b/opa/builtins.go @@ -6,6 +6,7 @@ import ( "github.com/open-policy-agent/opa/ast" "github.com/open-policy-agent/opa/rego" "github.com/open-policy-agent/opa/types" + "strings" ) func registerBuiltinFunctions() { @@ -65,6 +66,10 @@ func registerBuiltinFunctions() { return nil, err } + if strings.Count(versionStr, ".") <= 1 { + versionStr += ".9223372036854775807" + } + semver, err := version.NewVersion(versionStr) if err != nil { print(err)