Skip to content

Commit 15224ce

Browse files
Avinash Reddyborjapazr
andcommitted
feat(version): read app info from package.json (#174)
* package.json: follow npm Docs guidelines https://docs.npmjs.com/cli/v8/configuring-npm/package-json#people-fields-author-contributors * app.config.ts: read more stuff from package.json The package `read-pkg` allows for it, let's use it :) * package.json: fix author URL * fix tsc errors * fix(appinfo): ran prettier * Update .env Co-authored-by: Borja Paz Rodríguez <[email protected]>
1 parent 7b56d14 commit 15224ce

File tree

5 files changed

+28
-15
lines changed

5 files changed

+28
-15
lines changed

.env

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,19 @@
11
## App configuration ##
22
NODE_ENV=development
3-
APP_NAME=base-app
43
PORT=5000
54

5+
## App information overrides ##
6+
# By default, these are read from package.json #
7+
#APP_VERSION=
8+
APP_NAME=ets-api
9+
#APP_DESCRIPTION=
10+
#AUTHOR_NAME=
11+
#AUTHOR_EMAIL=
12+
#AUTHOR_WEBSITE=
13+
614
## Docker configuration ##
715
# App configuration #
16+
IMAGE_NAME=express-typescript-skeleton
817
EXTERNAL_PORT=5000
918
LOGS_VOLUME=../.docker/app/logs
1019

docker/docker-compose.dev.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ services:
88
- PORT=${PORT}
99
dockerfile: ./docker/Dockerfile
1010
target: dev
11-
image: ${APP_NAME}:dev
12-
container_name: ${APP_NAME}
11+
image: ${IMAGE_NAME}:dev
12+
container_name: ${IMAGE_NAME}
1313
restart: always
1414
depends_on:
1515
- db
@@ -52,4 +52,4 @@ volumes:
5252

5353
networks:
5454
default:
55-
name: ${APP_NAME}-network
55+
name: ${IMAGE_NAME}-network

docker/docker-compose.prod.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ services:
88
- PORT=${PORT}
99
dockerfile: ./docker/Dockerfile
1010
target: prod
11-
image: ${APP_NAME}:prod
12-
container_name: ${APP_NAME}
11+
image: ${IMAGE_NAME}:prod
12+
container_name: ${IMAGE_NAME}
1313
restart: always
1414
depends_on:
1515
- db
@@ -38,4 +38,4 @@ services:
3838

3939
networks:
4040
default:
41-
name: ${APP_NAME}-network
41+
name: ${IMAGE_NAME}-network

package.json

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,12 @@
11
{
2-
"name": "node-ts-skeleton",
2+
"name": "express-typescript-skeleton",
33
"version": "1.3.3",
4-
"description": "This is a template to start developing a REST API with Node.js (Express), TypeScript, Eslint, Prettier, Husky, etc.",
5-
"author": "Borja Paz Rodríguez (@borjapazr)",
4+
"description": "🔰🦸 Template to start developing a REST API with Node.js (Express), TypeScript, ESLint, Prettier, Husky, Prisma, etc.",
5+
"author": {
6+
"name": "Borja Paz Rodríguez",
7+
"email": "[email protected]",
8+
"url": "https://bpaz.dev"
9+
},
610
"license": "MIT",
711
"keywords": [
812
"node",

src/presentation/config/app.config.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ import { getEnvironmentNumber, getEnvironmentString } from '@infrastructure/shar
44

55
const AppInfo = {
66
APP_VERSION: getEnvironmentString('APP_VERSION', readPackageJsonSync().version),
7-
APP_NAME: getEnvironmentString('APP_NAME', 'base-app'),
8-
APP_DESCRIPTION: getEnvironmentString('APP_DESCRIPTION', '🚀 To infinity and beyond!'),
9-
AUTHOR_NAME: getEnvironmentString('AUTHOR_NAME', 'Borja Paz Rodríguez'),
10-
AUTHOR_EMAIL: getEnvironmentString('AUTHOR_EMAIL', '[email protected]'),
11-
AUTHOR_WEBSITE: getEnvironmentString('AUTHOR_WEBSITE', 'https://bpaz.dev')
7+
APP_NAME: getEnvironmentString('APP_NAME', readPackageJsonSync().name),
8+
APP_DESCRIPTION: getEnvironmentString('APP_DESCRIPTION', readPackageJsonSync().description || 'N/A'),
9+
AUTHOR_NAME: getEnvironmentString('AUTHOR_NAME', readPackageJsonSync().author?.name || 'N/A'),
10+
AUTHOR_EMAIL: getEnvironmentString('AUTHOR_EMAIL', readPackageJsonSync().author?.email || 'N/A'),
11+
AUTHOR_WEBSITE: getEnvironmentString('AUTHOR_WEBSITE', readPackageJsonSync().author?.url || 'N/A')
1212
};
1313

1414
const AppConfig = {

0 commit comments

Comments
 (0)