Skip to content

Commit b8c62e7

Browse files
authored
governance: updating review changes (envoyproxy#30995)
Risk Level: n/a Testing: n/a Docs Changes: yes Release Notes: no Signed-off-by: Alyssa Wilk <[email protected]>
1 parent 69481d2 commit b8c62e7

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

CONTRIBUTING.md

+8-7
Original file line numberDiff line numberDiff line change
@@ -237,18 +237,19 @@ Please note that if adding a runtime guarded feature, your [release notes](chang
237237
* Typically we try to turn around reviews within one business day.
238238
* See [OWNERS.md](OWNERS.md) for the current list of maintainers.
239239
* It is generally expected that a senior maintainer should review every PR to
240-
core code. Test-only or extension-only changes need only be reviewed by a
241-
maintainer, or senior extension maintainer.
240+
core code. Changes which only touch tests, extensions, tools, docs or comments
241+
need only be reviewed by a maintainer, or senior extension maintainer.
242242
* It is also generally expected that a "domain expert" for the code the PR touches should review the
243243
PR. This person does not necessarily need to have commit access.
244-
* The previous two points generally mean that every PR should have two approvals. (Exceptions can
245-
be made by the senior maintainers).
246-
* The above rules may be waived for PRs which only update docs or comments, or trivial changes to
247-
tests and tools (where trivial is decided by the maintainer in question).
248-
* In general, we should also attempt to make sure that at least one of the approvals is *from an
244+
* For new extensions (contrib or otherwise) and features, at least one of the approvals should be *from an
249245
organization different from the PR author.* E.g., if Lyft authors a PR, at least one approver
250246
should be from an organization other than Lyft. This helps us make sure that we aren't putting
251247
organization specific shortcuts into the code.
248+
new HTTP/3 features are largely exempt from cross-company approvals as all of the
249+
area experts work at a single company, but HTTP/3 changes which impact general
250+
functionality still merit a cross-company check.
251+
* contrib extensions do not need senior maintainer or maintainer review only contrib owner review and
252+
a maintainer stamp to merge.
252253
* If there is a question on who should review a PR please discuss in Slack.
253254
* Anyone is welcome to review any PR that they want, whether they are a maintainer or not.
254255
* Please make sure that the PR title, commit message, and description are updated if the PR changes

0 commit comments

Comments
 (0)