Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last Cleansing #139

Closed
14 tasks done
nils-schmitt opened this issue May 18, 2024 · 16 comments · Fixed by #144
Closed
14 tasks done

Last Cleansing #139

nils-schmitt opened this issue May 18, 2024 · 16 comments · Fixed by #144

Comments

@nils-schmitt
Copy link
Collaborator

nils-schmitt commented May 18, 2024

Here we should collect all the things, we see in the code check that are most certainly in the end product, but not desired.
Feel free to contribute!

Database:

  • Delete all admin users (except "admin")
  • Clean the DB one last time of unwanted PJs / Traces / Cohorts
  • Traces with cohorts
  • all traces have valid cohorts

Code:

  • Universal case convention for buttons
  • universal capitalization convention for html files
  • Remove all print()
  • check settings.py
  • remove migrations from comparator
  • delete tests
  • activity_labeler 76: false typing
  • clean post_processing
  • Snomed integration

Optional:

  • reset ids?
@PitButtchereit
Copy link
Collaborator

Buttons should have a universal case convention.

Bildschirmfoto 2024-05-21 um 12 49 56

@nils-schmitt

This comment was marked as resolved.

@PitButtchereit
Copy link
Collaborator

PitButtchereit commented May 22, 2024

module_metrics_analyzer.__rate_timestamp_correctness should use the liear_prob directly from the query_gpt() function

I've refactored this already on my branch 👍 New code now looks like this.

timestamp_correctness, linear_probability = u.query_gpt(messages, return_linear_probability=True, top_logprobs=1)
and I changed the return value of the function accordingly.

@PitButtchereit
Copy link
Collaborator

PitButtchereit commented May 24, 2024

This basically means having a final database image.

grafik

@nils-schmitt
Copy link
Collaborator Author

Remove all print statements

@PitButtchereit

This comment was marked as outdated.

@FR-SON
Copy link
Collaborator

FR-SON commented May 24, 2024

add valid cohorts for all traces remaining in the db

@FR-SON
Copy link
Collaborator

FR-SON commented May 24, 2024

In settings.py there are these two lines that should be addressed:

# SECURITY WARNING: keep the secret key used in production secret!
SECRET_KEY = "django-insecure-$u00r=^xd*m1ggjgzwj%2o2$h=34k358#imaxe22w@stk_aptt"

# SECURITY WARNING: don't run with debug turned on in production!
DEBUG = True

@FR-SON
Copy link
Collaborator

FR-SON commented May 24, 2024

Remove migrations directory from trace:comparator. It is empty aside from an init file so it should not be required. Especially because all models are located in the extraction app.

@nils-schmitt
Copy link
Collaborator Author

Push web scraping poc, with big future use annotation

@nils-schmitt

This comment was marked as outdated.

@PitButtchereit
Copy link
Collaborator

Fix ResultViewTests

How thou???

Delete

@nils-schmitt
Copy link
Collaborator Author

Clean TTE html files

@nils-schmitt
Copy link
Collaborator Author

Make html files similar regarding Capitalization of words

@FR-SON
Copy link
Collaborator

FR-SON commented May 26, 2024

Line 76 in module_activity_labler.py: user_message: List[str] = patient_journey_numberedhas wrong typing, should be str.

The functions inside post_processing in module_time_extractor.py use a variable df that shadows a variable from outer scope. It should be changed to _df inside those functions. Additionally the column parameter is typed as a pd.Series, but is actually a str

Image

@tkv29
Copy link
Collaborator

tkv29 commented May 27, 2024

image

@nils-schmitt nils-schmitt self-assigned this May 27, 2024
@nils-schmitt nils-schmitt linked a pull request May 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants