-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add <div> and <span> wrappers around edits #117
Comments
Hi. Sure, OK. Do you have particular edits in mind, or just generally? Could you show me, so I know exactly what you mean? Thanks, @frostyweather. |
Sure thing @FullCreamMilkMan! Basically all I am doing is removing the double brackets [[]] and replacing those with I am changing this:
To this:
I am doing this to basically give all of your edits a class name so I can turn the text red or give it a highlighted look to differentiate it from the actual content of the book. Sound good? |
Yeah, that's fine. When Brad has finished chapter 5, do you want me to wrap my edits like this, or can I leave that to you? |
Oh, and there are a couple of edits which I deliberately marked up so they remain hidden. Have you identified them? They're early on, I think, and only once or twice. They should stay hidden, though I can discuss that with Brad. |
@FullCreamMilkMan You can leave that to me if it is easier doing it the other way. I made the invisible ones visible I believe. Probably a good question to ask @bradfrost whether he wants these hidden or not. |
@FullCreamMilkMan Also, I created a new branch for this called edits-ian so we can always compare and contrast with the edits branch in case we do want to go back to the invisible state. |
I'll keep using the square braces for now – it'll be much easier for me and won't slow me down while editing. Hope that's OK. Thanks for setting up a new branch for your work. That'll keep things nice and neat, and like you say we can revert back as and when necessary. Great. Now I can start to get nervous as my usually unseen work prepares for the light of day! |
@FullCreamMilkMan Sounds good. That works for me. Your work will look great! haha |
@FullCreamMilkMan @frostyweather
If you feel like those should be hidden then we can do that. I'd ask why they're hidden (are you calling me ugly?) but if you feel strongly about keeping a few comments private, that's totally fine.
Hahaha it'll be fine! |
Add
<div>
and<span>
wrappers around the edits to style these chunks of text differently than the rest of the book. Just letting you know, @FullCreamMilkMan.The text was updated successfully, but these errors were encountered: