Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] NiftyReg doesn't deal with spaces in file names #4

Open
adamltyson opened this issue Jul 14, 2020 · 6 comments
Open

[BUG] NiftyReg doesn't deal with spaces in file names #4

adamltyson opened this issue Jul 14, 2020 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Milestone
0.0.1

Comments

@adamltyson
Copy link
Member

As with amap, see https://github.com/SainsburyWellcomeCentre/amap-python/issues/56
@adamltyson adamltyson added the bug Something isn't working label Jul 14, 2020
@adamltyson adamltyson added this to the 0.0.1 milestone Jul 14, 2020
@adamltyson adamltyson self-assigned this Jul 14, 2020
@adamltyson
Copy link
Member Author

I think this can be solved by just adding quotes to the paths sent to niftyreg.

@adamltyson adamltyson added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 18, 2021
@adamltyson
Copy link
Member Author

This is also an issue if brainreg is installed in a directory with spaces, as the path to niftyreg is used as a command to bash/cmd.

@adamltyson
Copy link
Member Author

Fixed in 649a915

@adamltyson
Copy link
Member Author

adamltyson commented Feb 14, 2022 •
edited
Loading

Not fully fixed - output files are incorrectly named.

@adamltyson adamltyson reopened this Feb 14, 2022
@JoeZiminski JoeZiminski mentioned this issue Aug 26, 2022
Merged
6 tasks
@adamltyson adamltyson removed their assignment Jan 10, 2023
@adamltyson
Copy link
Member Author

Closing this because I can't see any issue with the output filenames when the input has a space in the name. Can always reopen if we notice something.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Core development May 21, 2024
@adamltyson
Copy link
Member Author

This doesn't seem to be fully fixed, see https://forum.image.sc/t/unable-to-complete-brainreg-tuturial-affine-registration-failed/110045

@adamltyson adamltyson reopened this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
Core development
Status: Done
Milestone
0.0.1
Development

No branches or pull requests
1 participant
@adamltyson