Use legacy address with sparkscan

Author: danielgranhao

crates/breez-sdk/core/src/sdk.rs

@@ -341,7 +341,11 @@ impl BreezSdk {
             .unwrap_or_default();
         let last_synced_id = cached_sync_info.last_synced_payment_id;
 
-        let spark_address = self.spark_wallet.get_spark_address()?.to_string();
+        // TODO: use new spark address format once sparkscan supports it
+        let legacy_spark_address = self
+            .spark_wallet
+            .get_spark_address()?
+            .to_string_with_hrp_legacy();
 
         let mut payments_to_sync = Vec::new();
 
@@ -355,7 +359,7 @@ impl BreezSdk {
             let response = sparkscan::Client::new(&self.config.sparkscan_api_url)
                 .get_address_transactions_v1_address_address_transactions_get()
                 .network(sparkscan::types::Network::from(self.config.network))
-                .address(spark_address.to_string())
+                .address(legacy_spark_address.to_string())
                 .offset(next_offset)
                 .limit(PAYMENT_SYNC_BATCH_SIZE)
                 .send()
@@ -388,7 +392,7 @@ impl BreezSdk {
                 let payments = payments_from_address_transaction_and_ssp_request(
                     transaction,
                     ssp_user_requests.get(&transaction.id),
-                    &spark_address,
+                    &legacy_spark_address,
                 )?;
 
                 for payment in payments {

crates/spark/src/address/mod.rs

@@ -221,6 +221,15 @@ impl SparkAddress {
         }
     }
 
+    fn network_to_hrp_legacy(network: &Network) -> Hrp {
+        match network {
+            Network::Mainnet => HRP_LEGACY_MAINNET,
+            Network::Testnet => HRP_LEGACY_TESTNET,
+            Network::Regtest => HRP_LEGACY_REGTEST,
+            Network::Signet => HRP_LEGACY_SIGNET,
+        }
+    }
+
     fn hrp_to_network(hrp: &Hrp) -> Result<Network, AddressError> {
         match hrp {
             hrp if hrp == &HRP_MAINNET || hrp == &HRP_LEGACY_MAINNET => Ok(Network::Mainnet),
@@ -234,6 +243,15 @@ impl SparkAddress {
 
 impl Display for SparkAddress {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        let hrp = Self::network_to_hrp(&self.network);
+
+        let address = self.to_string_with_hrp(hrp);
+        write!(f, "{address}")
+    }
+}
+
+impl SparkAddress {
+    fn to_string_with_hrp(&self, hrp: Hrp) -> String {
         let spark_invoice_fields: Option<ProtoSparkInvoiceFields> =
             self.spark_invoice_fields.clone().map(|f| f.into());
 
@@ -245,11 +263,13 @@ impl Display for SparkAddress {
 
         let payload_bytes = proto_address.encode_to_vec();
 
-        let hrp = Self::network_to_hrp(&self.network);
-
         // This is safe to unwrap, because we are using a valid HRP and payload
-        let address = bech32::encode::<Bech32m>(hrp, &payload_bytes).unwrap();
-        write!(f, "{address}")
+        bech32::encode::<Bech32m>(hrp, &payload_bytes).unwrap()
+    }
+
+    pub fn to_string_with_hrp_legacy(&self) -> String {
+        let hrp = Self::network_to_hrp_legacy(&self.network);
+        self.to_string_with_hrp(hrp)
     }
 }