Skip to content

Drop Ruby 1.8.7 and REE support #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

nurse
Copy link
Contributor

@nurse nurse commented Jun 28, 2016

Their CI statuses are badly broken now: https://travis-ci.org/brianmario/mysql2/builds/124159847
(others are also broken but some of them can be fixed by #765)

@justincase
Copy link
Contributor

Related: #632

On 28 jun. 2016, at 12:52, NARUSE, Yui [email protected] wrote:

Their CI statuses are badly broken now: https://travis-ci.org/brianmario/mysql2/builds/124159847
(others are also broken but some of them can be fixed by #765)

You can view, comment on, or merge this pull request online at:

#766

Commit Summary

Drop Ruby 1.8.7 and REE support
File Changes

M .travis.yml (4)
M mysql2.gemspec (1)
Patch Links:

https://github.com/brianmario/mysql2/pull/766.patch
https://github.com/brianmario/mysql2/pull/766.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@sodabrew
Copy link
Collaborator

There's a segfault bug in #759 that should resolve the other test failures including 1.8.7 and ree. It's not a "normal case" in production, but the unit tests intentionally trigger it. I will remove the oldest Rubies eventually and pull out all of the encoding workarounds, but not today :)

@sodabrew sodabrew closed this Jun 28, 2016
@kamipo
Copy link
Contributor

kamipo commented Jun 28, 2016

I need to fix the issue #764 for rails/rails#25230.
But I heard from @nurse that Ruby 1.8.7 does not have rb_big_cmp.
Do we need to support Ruby 1.8.7 and ree for mysql2 0.4.x and fix #764 for the rubies?

@nurse nurse deleted the drop-ruby-1.8.7 branch June 29, 2016 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants