Error type in callback

Yash Ladha · Yash Ladha · commit 90025f934380 · 2020-01-24T14:41:44.000+05:30
diff --git a/index.d.ts b/index.d.ts
@@ -22,6 +22,6 @@ declare module "browserstack-local" {
   class Local {
     start(options: Partial<Options>, callback: (error?: Error) => void): void;
     isRunning(): boolean;
-    stop(callback: () => void): void;
+    stop(callback: (error?: Error) => void): void;
   }
 }
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "browserstack-local",
-  "version": "1.4.5",
+  "version": "1.4.6",
   "description": "Nodejs bindings for BrowserStack Local",
   "engine": "^0.10.44",
   "main": "index.js",

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,6 @@ declare module "browserstack-local" {`
`22`	`22`	`class Local {`
`23`	`23`	`start(options: Partial<Options>, callback: (error?: Error) => void): void;`
`24`	`24`	`isRunning(): boolean;`
`25`		`- stop(callback: () => void): void;`
	`25`	`+ stop(callback: (error?: Error) => void): void;`
`26`	`26`	`}`
`27`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "browserstack-local",`
`3`		`- "version": "1.4.5",`
	`3`	`+ "version": "1.4.6",`
`4`	`4`	`"description": "Nodejs bindings for BrowserStack Local",`
`5`	`5`	`"engine": "^0.10.44",`
`6`	`6`	`"main": "index.js",`