Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Irrelevant warnings because devDependencies are listed in dependencies #77

Closed
devoto13 opened this issue May 25, 2019 · 1 comment
Closed

Irrelevant warnings because devDependencies are listed in dependencies #77

devoto13 opened this issue May 25, 2019 · 1 comment

Comments

@devoto13
Copy link

Expected Behavior

npm install browserstack-local does not produce any warnings, when I install it.

Actual Behavior

$ npm install browserstack-local
npm WARN deprecated [email protected]: This package is unmaintained. Use @sinonjs/formatio instead
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam
npm WARN deprecated [email protected]: This package has been deprecated in favour of @sinonjs/samsam

Steps to Reproduce the Problem

  1. npm install browserstack-local

browserstack local arguments

Not relevant.

Platform details

  1. browserstack-local-nodejs version: latest
  2. node version: any
  3. os type and version: any

Details

Warnings come from the sinon dependency, which is only used in tests, but for some reason listed as a production dependency. There were several PRs (#54, #70, #71) attempting to fix this issue, which all were silently ignored. What is the problem? What needs to be done to get one of them reviewed and merged?

In particular #54 does not do any extra changes, which may be risky, but plainly removes unnecessary dependencies, so consumers don't have to install them and see irrelevant warning.
devoto13 added a commit to devoto13/karma that referenced this issue May 25, 2019
@devoto13
fix(test): force newer version of natives to fix failing tests on Nod…
0ae380e 
…e 10

natives module is actually deprecated, because it breaks on every new version of Node. We can get rid of it once we update karma-browserstack-launcher dependency, once browserstack/browserstack-local-nodejs#77 is resolved.
devoto13 added a commit to devoto13/karma that referenced this issue Jul 25, 2019
@devoto13
fix(test): force newer version of natives to fix failing tests on Nod…
adfd352 
…e 10

natives module is actually deprecated, because it breaks on every new version of Node. We can get rid of it once we update karma-browserstack-launcher dependency, once browserstack/browserstack-local-nodejs#77 is resolved.
@devoto13 devoto13 mentioned this issue Jul 26, 2019
Merged
@devoto13
Copy link
Author

Fixed by #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@devoto13