Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input representation as its own class #92

Closed
michelole opened this issue Apr 14, 2019 · 1 comment
Closed

Input representation as its own class #92

michelole opened this issue Apr 14, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@michelole
Copy link
Member

Currently, auxiliary methods such as getChar3GramVectorToSentence are mixed with iterator methods in classes that implement DataSetIterator. However, an iterator is not needed for e.g. prediction.

We should move such methods to a separate class.
@michelole michelole added the enhancement New feature or request label Apr 17, 2019
@michelole
Copy link
Member Author

Fixed by #111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michelole