Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Lexigram support #17

Closed
3 tasks done
michelole opened this issue Jul 12, 2018 · 0 comments
Closed
3 tasks done

Improve Lexigram support #17

michelole opened this issue Jul 12, 2018 · 0 comments
Assignees
@michelole

Comments

@michelole
Copy link
Member

michelole commented Jul 12, 2018 •
edited
Loading

@michelole michelole self-assigned this Jul 23, 2018
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
DRY Extract common code to function (refs bst-mug#17)
b944590 
This prepares for caching calls.
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
Add cache for Lexigram calls (refs bst-mug#17)
66c9646
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
DRY Wrap search API into its own method (refs bst-mug#17)
0dccc5b
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
DRY Wrap concept API into its own method (refs bst-mug#17)
ddd7a1f
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
Fail fast when we get an invalid answer from Lexigram API (refs bst-m…
a401923 
…ug#17)
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
DRY Extract endpoint to private variable (refs bst-mug#17)
f7a830d
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
Add support for ancestors from Lexigram API (refs bst-mug#17)
f7309a6
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
Make private methods private (refs bst-mug#17)
c57fc3e
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
Add method to get synonyms separately (refs bst-mug#17)
c844895
arianesasso pushed a commit to hpi-dhc/trec-pm that referenced this issue Nov 15, 2018
@michelole
Move Lexigram API key to properties (fixes bst-mug#17)
2618a79 
This ease key manipulation and allow injection via environment variable, which can be used not to skip tests during CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michelole michelole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michelole