Sonar: duplication — 9,792 duplicated lines (4.8%) across 139 files in 439 blocks

[sirdeggen]

Tracking issue for #38.

SonarCloud reports:

• 9,792 duplicated lines (4.8% density)
• 439 duplicated blocks
• 139 duplicated files

Suggested approach

1. Pull the duplications report from SonarCloud UI for top-offending file pairs.
2. Extract shared helpers into a utils or internal module per package.
3. For cross-package duplication (e.g. similar transaction-builder logic in helpers/bsv-wallet-helper and wallet/wallet-toolbox), evaluate whether a shared internal package is appropriate.

Reproduce

SonarCloud UI: https://sonarcloud.io/component_measures?id=bsv-blockchain_ts-stack&metric=duplicated_lines_density

Refs: #38

[sirdeggen]

Progress update (post-merge)

PR #55 merged (5f95c80). Extracted StorageClientBase + entityValidationHelpers + validateSyncChunkEntities. ~840 dup lines consolidated across StorageClient, StorageMobile, StorageServer in packages/wallet/wallet-toolbox/src/storage/remoting/.

Sonar metrics for that PR: new_duplicated_lines_density 7.5% → 0%.

Follow-up needed

Sonar QG flagged new_coverage = 0% on the extracted helpers. The helpers are pure utility functions that lend themselves to unit tests (no DB/storage dep needed). Suggest a follow-up PR to add coverage for:

• entityValidationHelpers.ts — validateDate, validateEntity, validateEntities, validateSyncChunkEntities
• StorageClientBase (test through one concrete subclass with mocks)

Remaining repo-wide

Sonar's overall duplication metrics still apply (439 blocks, 139 files, 4.8% density). One pair done as proof-of-pattern; many more candidates remain. Keep open.