Sonar: long-tail TypeScript smells (~600 issues across 50+ rules)

[sirdeggen]

Tracking issue for #38.

Remaining low-volume rules (each <30 issues), totaling ~600 across the repo. Mostly minor stylistic / consistency issues.

Examples:

• typescript:S6551 (16) — Should not stringify primitives implicitly
• typescript:S7723 (11) — Use Object.hasOwn over Object.prototype.hasOwnProperty.call
• typescript:S4623 (8) — Don't pass undefined to optional parameters
• typescript:S4782 (7) — Property type unions should not contain undefined
• typescript:S6647 (3) — Empty constructors are redundant
• typescript:S3863 (4) — Modules should not have multiple imports
• typescript:S2004 (3) — Functions should not be nested too deeply
• typescript:S6353 (3) — Concise character class syntax
• typescript:S3735 (2) — void should not be used as a value
• typescript:S6819 (2) — Don't use semantic tags as div replacements
• typescript:S6842 (2) — Use the role attribute appropriately
• typescript:S3516 (2) — Functions returning the same value (already addressed locally)
• docker:S7031 (1) — Specify a tag for base images
• ... and ~40 more.

Suggested approach

Pull the full list from SonarCloud UI (Issues tab, group by rule) and assign per-rule to whoever's most familiar with the affected area. Most are 1-3 lines each.

Reproduce

curl -s -u "$SONAR_TOKEN:" \
  "https://sonarcloud.io/api/issues/search?componentKeys=bsv-blockchain_ts-stack&resolved=false&ps=500" \
  | jq -r '.issues[] | "\(.rule)\t\(.component):\(.line)\t\(.message)"'

Refs: #38

[sirdeggen]

Progress update (post-merge)

PR #52 merged (75fdda4). Cleared:

Rule	Before	After
typescript:S6647 (empty constructors)	3	0 ✅

Remaining long-tail rules

(Sonar latest, total ~600 spread across 50+ rules)

Rule	Count	Description
typescript:S6551	(check)	Implicit primitive stringification
typescript:S7723	(check)	Object.hasOwn over hasOwnProperty.call
typescript:S4623	(check)	Don't pass undefined to optional params
typescript:S4782	(check)	Type unions w/ undefined
typescript:S3863	(check)	Multiple imports per module
typescript:S2004	(check)	Functions nested too deeply
typescript:S6353	(check)	Concise character class
typescript:S3735	(check)	void as value
typescript:S6819 / S6842	(check)	Accessibility tags
docker:S7031	(check)	Specify base image tag
...		~40 more rules

Keeping open. Pull full list via:

curl -u "$SONAR_TOKEN:" "https://sonarcloud.io/api/issues/search?componentKeys=bsv-blockchain_ts-stack&resolved=false&ps=500" | jq -r '.issues[] | "\(.rule)\t\(.component):\(.line)"'