Skip to content

Harden paid wallet setup failures#225

Closed
ty-everett wants to merge 6 commits into
mainfrom
codex/wallet-paid-setup-failures
Closed

Harden paid wallet setup failures#225
ty-everett wants to merge 6 commits into
mainfrom
codex/wallet-paid-setup-failures

Conversation

@ty-everett

Copy link
Copy Markdown
Collaborator

Summary

  • Wrap paid AuthFetch payment creation failures with a direct funding error while preserving the original cause.
  • Redact raw payment transaction payloads and derivation suffixes from payment retry logs and failure details.
  • Wrap SHIP/SLAP advertisement transaction funding failures with actionable advertiser-wallet context.
  • Bump and sync the affected ts-stack package versions so the fixes can be published and consumed by CARS/wallet release tooling.

Root Cause

The CARS release path was reaching storage, but release wallet setup could fail below the transport layer when paid storage/auth or advertisement issuance required spendable wallet funds. The old error path could be masked as a generic storage timeout and could also emit raw payment payloads into logs.

Validation

  • corepack pnpm check-versions
  • corepack pnpm --filter @bsv/sdk --filter @bsv/wallet-toolbox --filter @bsv/overlay-discovery-services --filter @bsv/wallet-toolbox-client --filter @bsv/wallet-toolbox-mobile run build

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.19048% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/sdk/src/auth/clients/AuthFetch.ts 57.14% 3 Missing ⚠️
packages/sdk/src/auth/Peer.ts 85.71% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ty-everett ty-everett closed this Jun 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant