test(react-native-cli): check that the built artifact exists after building

Author: yousif-bugsnag

test/react-native-cli/features/build-app-tests/build-android-app.feature

@@ -10,3 +10,5 @@ Feature: Tests for building a React Native app (for Android only) that was initi
     And the sourcemap payload field "apiKey" equals "1234567890ABCDEF1234567890ABCDEF"
     And the sourcemap payload field "platform" equals "android"
     And the sourcemap payload field "overwrite" equals "true"
+
+    And the APK file exists

test/react-native-cli/features/build-app-tests/build-ios-app.feature

@@ -13,4 +13,5 @@ Feature: Tests for building a React Native app (for iOS only) that was initializ
 
     # Re-archive and export an IPA that can be used for subsequent tests
     Then I export the iOS archive
+    And the IPA file exists
 

test/react-native-cli/features/steps/steps.rb

@@ -1,9 +1,9 @@
 require 'rexml/document'
 require 'securerandom'
 
-fixtures = Dir["#{__dir__}/../fixtures/rn0_*"].map { |dir| File.basename(dir) }.sort
 current_fixture = ENV['RN_VERSION']
 fixture_dir = "#{__dir__}/../../../react-native-cli/features/fixtures/generated/"
+generate_fixture_script = "#{__dir__}/../../../../scripts/generate-react-native-cli-fixture.js"
 
 # if RCT_NEW_ARCH_ENABLED is set add new-arch/ to the fixture_dir
 if ENV['RCT_NEW_ARCH_ENABLED'] == 'true' || ENV['RCT_NEW_ARCH_ENABLED'] == '1'
@@ -16,25 +16,8 @@
   step("I run the service '#{current_fixture}' interactively")
 end
 
-def find_cli_helper_script
-  # Handle both Dockerized and local Maze Runner executions
-  script = 'generate-react-native-cli-fixture.js'
-  possible_locations = %W[
-    #{__dir__}/../../../../scripts/#{script}
-  ]
-  path = possible_locations.find { |path| File.exist?(path) }
-  if path.nil?
-    raise <<~ERROR
-      The React Native CLI helper script was not found in any of the expected locations:
-        - #{possible_locations.join("\n  -")}
-    ERROR
-  end
-  path
-end
-
 When('I build the Android app') do
-  script_path = find_cli_helper_script
-  $logger.info `node #{script_path}`
+  $logger.info `node #{generate_fixture_script}`
 
   # Change directory to fixture_dir
   Dir.chdir(fixture_dir) do
@@ -43,8 +26,7 @@ def find_cli_helper_script
 end
 
 When('I build the iOS app') do
-  script_path = find_cli_helper_script
-  $logger.info `node #{script_path}`
+  $logger.info `node #{generate_fixture_script}`
 
   # Change directory to fixture_dir
   Dir.chdir(fixture_dir) do
@@ -57,6 +39,16 @@ def find_cli_helper_script
   $logger.info `node -e 'require("#{script_path}").buildIPA("#{fixture_dir}")'`
 end
 
+When('the APK file exists') do
+  apk_path = "#{fixture_dir}/reactnative.apk"
+  Maze.check.true(File.exist?(apk_path))
+end
+
+When('the IPA file exists') do
+  ipa_path = "#{fixture_dir}/output/reactnative.ipa"
+  Maze.check.true(File.exist?(ipa_path))
+end
+
 def parse_package_json
   stdout_lines = Maze::Runner.interactive_session.stdout_lines
   length_before = stdout_lines.length