Docker: provide an easy way for installing additional utilities

[Nottt]

The docker image doesn't have curl installed. I need this in my script.

Am I missing something or there is no way to automatically install the dependencies needed for a script in the docker?

It would be nice if we could have something like dependencies: curl, jq, whatever and then you install then on docker start

[bugy]

Hi @Nottt,
as of my Docker knowledge, you would need to build a custom image, and your Dockerfile would look like this:

FROM docker push bugy/script-server:latest

RUN apk add --update \
    curl \
    jq \
    whatever \
    && rm -rf /var/cache/apk/*

On another side, probably it would be nice to have a default "fat" image of Script server with the most popular command-line utilities preinstalled

[Nottt]

My workaround is to just include apt update > /dev/null 2>&1 && apt install curl -y > /dev/null 2>&1 in my script

Instead of building a "fat" docker, you could implement s6-overlay so you can run post-boot scripts.

Then you could add a dependencies in your json, and a post-boot script would install all of them.

It's really easy to implement s6, you can take a look at one of my dockerfile for a template

That way you keep your image size minimal, with the ability to be extended at will at run time

[bugy]

I think s6 overlay would be useful in anycase, because Script server spawns quite a lot of the processes :)
I would keep this issue open (and rename to better reflect the intent behind it). But unfortunately I wouldn't have time to work on it in the nearest future.
If you have time/willingness, I would appreacite any PRs here :)

[Nottt]

I don't know python, and know very little about json, so I can't add a dependencies to your script configs json, but I can definitely try to dockerize your app with s6-overlay provided I don't have to do lots of reverse engineering xD

I can create a folder that people can put bash scripts that install the things they need at run time, but then I'm not sure if that's better than just warning people on the wiki to do this inside the script they are already running.

[bugy]

I wouldn't mix docker with Script server functionality, i.e. how you install dependencies
In a very long term having "dependencies" in every script config or a server config would be a nice feature.

But as for me, using custom Dockerfiles or s6 post-boot would be a good enough alternative. If you could prepare a Dockerfile (a new one or update existing one) to work with s6, I think it would be fantastic! And then we would need to find a way, how people would be able to supply boot scripts (if needed)

Installing everything in every script looks a bit weird too me :)

[Nottt]

I'll take a look at this. If there's everything you think I should know about how to install your app in ubuntu 18.04 then let me know now because it will be useful when creating the docker

Also where I can get this build/script-server docker? What it does exactly? Can't I just download latest release and execute the launcher.py ?

They would supply their own scripts that install what they need using a volume.

#!/usr/bin/with-contenv bash
# shellcheck shell=bash

if [[ -d "/app/scripts/dep" ]]; then
    for script in "/config/scripts/dep/"*; do
        ${script}
    done
fi

This would execute at run time any script people put in this folder inside the docker

I'm open to suggestions on the naming too.

[bugy]

Can we base it on alpine (which is current) or debian please? :)
I really don't trust ubuntu and the image is also quite large

Current Dockerfile is in
https://github.com/bugy/script-server/blob/master/tools/Dockerfile
The build script for it:
https://github.com/bugy/script-server/blob/master/tools/deploy_docker.sh

These guys are a part of CI process, and they access the build directly, without going to the latest releases

[bugy]

Regarding the volume thing, looks good enough for me

[bugy]

Please create a separate issue for the question and we discuss it there

[Nottt]

I finally got some time to work on this...so just to confirm, is the latest release 1.14.0?

But it'd prefer if we could have a static URL hosting the latest files with last commits, or I can just git clone your repo on the docker

Do you suggest a better way to keep the docker updated?

[Nottt]

So digging around I found some stuff, please correct me if wrong.

The web files you get is from init.py is the dev release, is not current right? So i tried to use your web-src folder but then I can't start the launcher script "web folder is invalid."

I see days olds commit in that folder, so what is the best way to be retrieve your web files?

As you know, I need the nginx authentication feature, so I'm trying to emulate your behavior on the dev docker